Bug 83340 – [BlackBerry] Enable vibration for the BlackBerry port

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[George Staikos]

Created attachment 135950 [details]
Patch to enable vibration

Enable the vibration API for BlackBerry.

[WebKit Review Bot]

Attachment 135950 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebKit/ChangeLog', u'..." exit_code: 1
ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/blackberry/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/blackberry/WebCoreSupport/VibrationClientBlackBerry.cpp:20:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/WebKit/blackberry/WebCoreSupport/VibrationClientBlackBerry.h:29:  Missing space inside { }.  [whitespace/braces] [5]
Total errors found: 5 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[George Staikos]

Created attachment 135954 [details]
Patch to enable vibration

[Rob Buis]

Comment on attachment 135954 [details]
Patch to enable vibration

View in context: https://bugs.webkit.org/attachment.cgi?id=135954&action=review

Looks good.

> Source/WebKit/blackberry/WebCoreSupport/VibrationClientBlackBerry.cpp:30
> +}

May want to keep this in the header inline for now.

> Source/WebKit/blackberry/WebCoreSupport/VibrationClientBlackBerry.cpp:38
> +{

Ditto.

> Source/cmake/OptionsBlackBerry.cmake:178
> +WEBKIT_FEATURE(ENABLE_VIBRATION "Enable vibration support" DEFAULT ON)

Any change needed in build-webkit? cmakeconfig.cmake? Usually they go hand-in-hand.

[George Staikos]

(In reply to comment #3)
> (From update of attachment 135954 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135954&action=review
> 
> Looks good.
> 
> > Source/WebKit/blackberry/WebCoreSupport/VibrationClientBlackBerry.cpp:30
> > +}
> 
> May want to keep this in the header inline for now.
> 
> > Source/WebKit/blackberry/WebCoreSupport/VibrationClientBlackBerry.cpp:38
> > +{
> 
> Ditto.
> 
> > Source/cmake/OptionsBlackBerry.cmake:178
> > +WEBKIT_FEATURE(ENABLE_VIBRATION "Enable vibration support" DEFAULT ON)
> 
> Any change needed in build-webkit? cmakeconfig.cmake? Usually they go hand-in-hand.

build-webkit change will go in separately later.  cmakeconfig change is already there.  Actually it's very annoying that we need to change build-webkit.  We should be able to turn things on by default if they're not specified there.

[WebKit Review Bot]

Comment on attachment 135954 [details]
Patch to enable vibration

Clearing flags on attachment: 135954

Committed r113404: <http://trac.webkit.org/changeset/113404>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[George Staikos]

Created attachment 136037 [details]
Turn on vibration by default now

[George Staikos]

Reopen pending the build-webkit patch

[Rob Buis]

Comment on attachment 136037 [details]
Turn on vibration by default now

LGTM.

[WebKit Review Bot]

Comment on attachment 136037 [details]
Turn on vibration by default now

Clearing flags on attachment: 136037

Committed r113489: <http://trac.webkit.org/changeset/113489>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.