Bug 83340 - [BlackBerry] Enable vibration for the BlackBerry port
Summary: [BlackBerry] Enable vibration for the BlackBerry port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: George Staikos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-05 18:04 PDT by George Staikos
Modified: 2012-04-06 13:13 PDT (History)
4 users (show)

See Also:


Attachments
Patch to enable vibration (8.04 KB, patch)
2012-04-05 18:04 PDT, George Staikos
no flags Details | Formatted Diff | Diff
Patch to enable vibration (8.20 KB, patch)
2012-04-05 18:11 PDT, George Staikos
no flags Details | Formatted Diff | Diff
Turn on vibration by default now (1.25 KB, patch)
2012-04-06 09:55 PDT, George Staikos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description George Staikos 2012-04-05 18:04:22 PDT
Created attachment 135950 [details]
Patch to enable vibration

Enable the vibration API for BlackBerry.
Comment 1 WebKit Review Bot 2012-04-05 18:08:14 PDT
Attachment 135950 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebKit/ChangeLog', u'..." exit_code: 1
ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/blackberry/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit/blackberry/WebCoreSupport/VibrationClientBlackBerry.cpp:20:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/WebKit/blackberry/WebCoreSupport/VibrationClientBlackBerry.h:29:  Missing space inside { }.  [whitespace/braces] [5]
Total errors found: 5 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 George Staikos 2012-04-05 18:11:34 PDT
Created attachment 135954 [details]
Patch to enable vibration
Comment 3 Rob Buis 2012-04-05 18:16:31 PDT
Comment on attachment 135954 [details]
Patch to enable vibration

View in context: https://bugs.webkit.org/attachment.cgi?id=135954&action=review

Looks good.

> Source/WebKit/blackberry/WebCoreSupport/VibrationClientBlackBerry.cpp:30
> +}

May want to keep this in the header inline for now.

> Source/WebKit/blackberry/WebCoreSupport/VibrationClientBlackBerry.cpp:38
> +{

Ditto.

> Source/cmake/OptionsBlackBerry.cmake:178
> +WEBKIT_FEATURE(ENABLE_VIBRATION "Enable vibration support" DEFAULT ON)

Any change needed in build-webkit? cmakeconfig.cmake? Usually they go hand-in-hand.
Comment 4 George Staikos 2012-04-05 18:17:53 PDT
(In reply to comment #3)
> (From update of attachment 135954 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135954&action=review
> 
> Looks good.
> 
> > Source/WebKit/blackberry/WebCoreSupport/VibrationClientBlackBerry.cpp:30
> > +}
> 
> May want to keep this in the header inline for now.
> 
> > Source/WebKit/blackberry/WebCoreSupport/VibrationClientBlackBerry.cpp:38
> > +{
> 
> Ditto.
> 
> > Source/cmake/OptionsBlackBerry.cmake:178
> > +WEBKIT_FEATURE(ENABLE_VIBRATION "Enable vibration support" DEFAULT ON)
> 
> Any change needed in build-webkit? cmakeconfig.cmake? Usually they go hand-in-hand.

build-webkit change will go in separately later.  cmakeconfig change is already there.  Actually it's very annoying that we need to change build-webkit.  We should be able to turn things on by default if they're not specified there.
Comment 5 WebKit Review Bot 2012-04-05 19:27:50 PDT
Comment on attachment 135954 [details]
Patch to enable vibration

Clearing flags on attachment: 135954

Committed r113404: <http://trac.webkit.org/changeset/113404>
Comment 6 WebKit Review Bot 2012-04-05 19:27:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 George Staikos 2012-04-06 09:55:22 PDT
Created attachment 136037 [details]
Turn on vibration by default now
Comment 8 George Staikos 2012-04-06 09:55:42 PDT
Reopen pending the build-webkit patch
Comment 9 Rob Buis 2012-04-06 09:56:13 PDT
Comment on attachment 136037 [details]
Turn on vibration by default now

LGTM.
Comment 10 WebKit Review Bot 2012-04-06 13:13:00 PDT
Comment on attachment 136037 [details]
Turn on vibration by default now

Clearing flags on attachment: 136037

Committed r113489: <http://trac.webkit.org/changeset/113489>
Comment 11 WebKit Review Bot 2012-04-06 13:13:05 PDT
All reviewed patches have been landed.  Closing bug.