RESOLVED FIXED 83277
[EFL] Create baselines for tests related to caret behaviour
https://bugs.webkit.org/show_bug.cgi?id=83277
Summary [EFL] Create baselines for tests related to caret behaviour
Sudarsana Nagineni (babu)
Reported 2012-04-05 07:27:05 PDT
The following test cases are failing because the PlatformKeyboardEvent doesn't receive the correct keyname(event->string) from DRT EventSender. editing/input/caret-at-the-edge-of-contenteditable.html editing/input/reveal-caret-of-multiline-contenteditable.html editing/input/reveal-caret-of-multiline-input.html
Attachments
Patch (49.27 KB, patch)
2012-04-17 02:24 PDT, Sudarsana Nagineni (babu)
no flags
Patch (49.27 KB, patch)
2012-04-17 03:42 PDT, Sudarsana Nagineni (babu)
no flags
Sudarsana Nagineni (babu)
Comment 1 2012-04-17 01:51:18 PDT
> editing/input/caret-at-the-edge-of-contenteditable.html > editing/input/reveal-caret-of-multiline-contenteditable.html > editing/input/reveal-caret-of-multiline-input.html KeyEvent issue is now fixed in r114250. These tests needs png and txt rebaseline to unksip.
Sudarsana Nagineni (babu)
Comment 2 2012-04-17 02:24:19 PDT
Created attachment 137500 [details] Patch Adding baselines and unskipping tests related to cursor positioning behavior
Gyuyoung Kim
Comment 3 2012-04-17 02:33:33 PDT
Comment on attachment 137500 [details] Patch Looks good to me. Thank you.
Sudarsana Nagineni (babu)
Comment 4 2012-04-17 03:42:27 PDT
Created attachment 137508 [details] Patch fix changelog entry
WebKit Review Bot
Comment 5 2012-04-17 08:37:14 PDT
Comment on attachment 137508 [details] Patch Rejecting attachment 137508 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: bKit/chromium/ui --revision 132474 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 46>At revision 132474. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Total errors found: 0 in 0 files Full output: http://queues.webkit.org/results/12417674
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-04-17 09:58:32 PDT
Comment on attachment 137508 [details] Patch cq+'ing again to see if it was a temporary problem in the commit bot.
WebKit Review Bot
Comment 7 2012-04-17 11:19:40 PDT
Comment on attachment 137508 [details] Patch Clearing flags on attachment: 137508 Committed r114399: <http://trac.webkit.org/changeset/114399>
WebKit Review Bot
Comment 8 2012-04-17 11:19:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.