Several LayoutTests require @font-face to be working. This seems to fail, e.g. at least in the new tests from bug 34147: /fast/css/font-face-synthetic-bold-italic.html /fast/css/font-face-weight-matching.html
Created attachment 137667 [details] Inverting switch logic for storing custom font data Feedback from Chromium people is appreciated.
Comment on attachment 137667 [details] Inverting switch logic for storing custom font data View in context: https://bugs.webkit.org/attachment.cgi?id=137667&action=review > Source/WebCore/loader/cache/CachedFont.cpp:30 > +#if !(PLATFORM(CHROMIUM) && OS(DARWIN) && USE(CG)) && !PLATFORM(WIN_CAIRO) && !PLATFORM(WX) Since we no longer use CG in Chromium, I don't think that condition is even needed here. Elliot?
(In reply to comment #2) > (From update of attachment 137667 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137667&action=review > > > Source/WebCore/loader/cache/CachedFont.cpp:30 > > +#if !(PLATFORM(CHROMIUM) && OS(DARWIN) && USE(CG)) && !PLATFORM(WIN_CAIRO) && !PLATFORM(WX) > > Since we no longer use CG in Chromium, I don't think that condition is even needed here. Elliot? Well, (PLATFORM(CHROMIUM) && OS(DARWIN) && USE(CG)) should always evaluate to FALSE, because as of http://trac.webkit.org/changeset/110056 , the Chromium gyp files within WebKit won't use CG. There is still cleanup that needs to be done to get rid of all the lingering Chromium+CG code... tracked in http://crbug.com/110881 ('cleanup: remove use_skia=0 build option')
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 137667 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=137667&action=review > > > > > Source/WebCore/loader/cache/CachedFont.cpp:30 > > > +#if !(PLATFORM(CHROMIUM) && OS(DARWIN) && USE(CG)) && !PLATFORM(WIN_CAIRO) && !PLATFORM(WX) > > > > Since we no longer use CG in Chromium, I don't think that condition is even needed here. Elliot? > > Well, (PLATFORM(CHROMIUM) && OS(DARWIN) && USE(CG)) should always evaluate to FALSE, because as of http://trac.webkit.org/changeset/110056 , the Chromium gyp files within WebKit won't use CG. > > There is still cleanup that needs to be done to get rid of all the lingering Chromium+CG code... tracked in http://crbug.com/110881 ('cleanup: remove use_skia=0 build option') So, can I conclude that #if !PLATFORM(WIN_CAIRO) && !PLATFORM(WX) would be enough?
(In reply to comment #4) > So, can I conclude that > #if !PLATFORM(WIN_CAIRO) && !PLATFORM(WX) > would be enough? As far as I know, yes.
Created attachment 137704 [details] Inverting switch logic for storing custom font data Chromium case removed after feedback from Chromium people.
Comment on attachment 137704 [details] Inverting switch logic for storing custom font data Clearing flags on attachment: 137704 Committed r114523: <http://trac.webkit.org/changeset/114523>
All reviewed patches have been landed. Closing bug.