Bug 83253 – [BlackBerry] Clear local storage won't take effect until browser exit and relaunch

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Jonathan Dong]

RIM PR: #146871

way to reproduce:
1. goto http://html5demos.com/storage, enter something both in session storage
and local storage, then reload the page, you can see the session and local
storage are there;
2. clear local storage;
3. refresh the page.

expected behavior:
session storage still there, local storage is empty;
now:
session storage and local storage are still there both. if you exit and
relaunch the browser, the local storage is cleared.


root cause:
in WebPageClientImpl::clearLocalStorage(), we only deleted the storage database
file on disk, but we haven't cleared the local storage in memory.

[Jonathan Dong]

Created attachment 135769 [details]
Patch

[Jonathan Dong]

Created attachment 135780 [details]
Patch

[Charles Wei]

Comment on attachment 135780 [details]
Patch

Looks good to me.  Need a reviewer to review and approve though.

[Rob Buis]

Comment on attachment 135780 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135780&action=review

Looks good.

> Source/WebKit/blackberry/Api/BlackBerryGlobal.cpp:139
>  void clearDatabase(const WebString& pageGroupName)

I wonder if clearDatabase is still in use...

[WebKit Review Bot]

Comment on attachment 135780 [details]
Patch

Clearing flags on attachment: 135780

Committed r113309: <http://trac.webkit.org/changeset/113309>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.