Bug 83252 - [BlackBerry] Empty Referrer should not be set into ResourceRequest when loading a main resource.
Summary: [BlackBerry] Empty Referrer should not be set into ResourceRequest when loadi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-04 23:52 PDT by Jason Liu
Modified: 2012-04-05 19:51 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.89 KB, patch)
2012-04-05 02:49 PDT, Jason Liu
no flags Details | Formatted Diff | Diff
Patch (2.75 KB, patch)
2012-04-05 04:17 PDT, Jason Liu
no flags Details | Formatted Diff | Diff
Patch (2.75 KB, patch)
2012-04-05 04:25 PDT, Jason Liu
no flags Details | Formatted Diff | Diff
Patch (2.75 KB, patch)
2012-04-05 04:37 PDT, Jason Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Liu 2012-04-04 23:52:18 PDT
We shouldn't set empty Referrer if there is not a Referrer at all.
Comment 1 Jason Liu 2012-04-05 02:49:56 PDT
Created attachment 135790 [details]
Patch
Comment 2 Leo Yang 2012-04-05 03:17:16 PDT
Comment on attachment 135790 [details]
Patch

LGTM.
Comment 3 Leo Yang 2012-04-05 03:22:52 PDT
Comment on attachment 135790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135790&action=review

> LayoutTests/http/tests/misc/resources/referrer-main-resource-expected.txt:1
> +PASS: The server doesn't receive a referrer.

Nit: doesn't --> didn't

> LayoutTests/http/tests/misc/resources/referrer-main-resource.php:13
> +        document.write("PASS: The server doesn't receive a referrer.");

Ditto.
Comment 4 Charles Wei 2012-04-05 03:39:52 PDT
Comment on attachment 135790 [details]
Patch

Test case can be made simpler by echo the corresponding JS code directly, instead of into "var result", which need to be processed in the client side.
Comment 5 Jason Liu 2012-04-05 04:17:46 PDT
Created attachment 135799 [details]
Patch
Comment 6 Jason Liu 2012-04-05 04:25:14 PDT
Created attachment 135801 [details]
Patch
Comment 7 Rob Buis 2012-04-05 04:27:46 PDT
Comment on attachment 135801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135801&action=review

> LayoutTests/http/tests/misc/resources/referrer-main-resource.php:12
> +        layoutTestController.dumpAsText();

This is usually done before the actual test, have a look at other tests.
Comment 8 Jason Liu 2012-04-05 04:37:29 PDT
Created attachment 135803 [details]
Patch
Comment 9 Charles Wei 2012-04-05 18:32:29 PDT
Comment on attachment 135803 [details]
Patch

Looks good to me.  Need an webkit reviewer to approve.
Comment 10 WebKit Review Bot 2012-04-05 19:51:22 PDT
Comment on attachment 135803 [details]
Patch

Clearing flags on attachment: 135803

Committed r113406: <http://trac.webkit.org/changeset/113406>
Comment 11 WebKit Review Bot 2012-04-05 19:51:27 PDT
All reviewed patches have been landed.  Closing bug.