Bug 83252 – [BlackBerry] Empty Referrer should not be set into ResourceRequest when loading a main resource.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Jason Liu]

We shouldn't set empty Referrer if there is not a Referrer at all.

[Jason Liu]

Created attachment 135790 [details]
Patch

[Leo Yang]

Comment on attachment 135790 [details]
Patch

LGTM.

[Leo Yang]

Comment on attachment 135790 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135790&action=review

> LayoutTests/http/tests/misc/resources/referrer-main-resource-expected.txt:1
> +PASS: The server doesn't receive a referrer.

Nit: doesn't --> didn't

> LayoutTests/http/tests/misc/resources/referrer-main-resource.php:13
> +        document.write("PASS: The server doesn't receive a referrer.");

Ditto.

[Charles Wei]

Comment on attachment 135790 [details]
Patch

Test case can be made simpler by echo the corresponding JS code directly, instead of into "var result", which need to be processed in the client side.

[Jason Liu]

Created attachment 135799 [details]
Patch

[Jason Liu]

Created attachment 135801 [details]
Patch

[Rob Buis]

Comment on attachment 135801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135801&action=review

> LayoutTests/http/tests/misc/resources/referrer-main-resource.php:12
> +        layoutTestController.dumpAsText();

This is usually done before the actual test, have a look at other tests.

[Jason Liu]

Created attachment 135803 [details]
Patch

[Charles Wei]

Comment on attachment 135803 [details]
Patch

Looks good to me.  Need an webkit reviewer to approve.

[WebKit Review Bot]

Comment on attachment 135803 [details]
Patch

Clearing flags on attachment: 135803

Committed r113406: <http://trac.webkit.org/changeset/113406>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.