The blackberry porting is using a different way to accelerate plugins.
Created attachment 135759 [details]
Comment on attachment 135759 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=135759&action=review
if (widget() && widget()->isPluginViewBase() && static_cast<PluginViewBase*>(widget())->platformLayer())
Then even if the code after that changes, we keep doing the right thing for plugins.
Created attachment 135965 [details]
Revised to follow Rob's suggestion
Comment on attachment 135965 [details]
Sorry, Leo, but I do not want to add a #if plat(bb) here like this. I would suggest:
- make a helper with a meaningful name, and add if's there. Maybe even a static local function.
- add a setting, where bb is the only platform that default returns false.
also it would be good to mention where in the code blackberry port we HW accelerate plugin layers, etc.