Bug 83248 - [BlackBerry] Upstream the BlackBerry change to rendering/RenderPart.cpp
Summary: [BlackBerry] Upstream the BlackBerry change to rendering/RenderPart.cpp
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leo Yang
Depends on:
Blocks: 73144
  Show dependency treegraph
Reported: 2012-04-04 22:59 PDT by Leo Yang
Modified: 2014-01-28 08:11 PST (History)
7 users (show)

See Also:

Patch (2.23 KB, patch)
2012-04-04 23:04 PDT, Leo Yang
no flags Details | Formatted Diff | Diff
Patch v2 (2.39 KB, patch)
2012-04-05 18:48 PDT, Leo Yang
tonikitoo: review-
tonikitoo: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2012-04-04 22:59:07 PDT
The blackberry porting is using a different way to accelerate plugins.
Comment 1 Leo Yang 2012-04-04 23:04:48 PDT
Created attachment 135759 [details]
Comment 2 Rob Buis 2012-04-05 03:53:06 PDT
Comment on attachment 135759 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=135759&action=review

> Source/WebCore/rendering/RenderPart.cpp:86
> +#endif

How about:
if (widget() && widget()->isPluginViewBase() && static_cast<PluginViewBase*>(widget())->platformLayer())
    return true;
    return false;

Then even if the code after that changes, we keep doing the right thing for plugins.
Comment 3 Leo Yang 2012-04-05 18:48:35 PDT
Created attachment 135965 [details]
Patch v2

Revised to follow Rob's suggestion
Comment 4 Antonio Gomes 2012-04-10 08:28:42 PDT
Comment on attachment 135965 [details]
Patch v2

Sorry, Leo, but I do not want to add a #if plat(bb) here like this. I would suggest:

- make a helper with a meaningful name, and add if's there. Maybe even a static local function.
- add a setting, where bb is the only platform that default returns false.

also it would be good to mention where in the code blackberry port we HW accelerate plugin layers, etc.