[BlackBerry] Upstream the BlackBerry change to rendering/RenderPart.cpp

[Leo Yang]

The blackberry porting is using a different way to accelerate plugins.

[Leo Yang]

Created attachment 135759 [details]
Patch

[Rob Buis]

Comment on attachment 135759 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135759&action=review

> Source/WebCore/rendering/RenderPart.cpp:86
> +#endif

How about:
if (widget() && widget()->isPluginViewBase() && static_cast<PluginViewBase*>(widget())->platformLayer())
#if !PLATFORM(BLACKBERRY)
    return true;
#else
    return false;
#endif

Then even if the code after that changes, we keep doing the right thing for plugins.

[Leo Yang]

Created attachment 135965 [details]
Patch v2

Revised to follow Rob's suggestion

[Antonio Gomes]

Comment on attachment 135965 [details]
Patch v2

Sorry, Leo, but I do not want to add a #if plat(bb) here like this. I would suggest:

- make a helper with a meaningful name, and add if's there. Maybe even a static local function.
- add a setting, where bb is the only platform that default returns false.

also it would be good to mention where in the code blackberry port we HW accelerate plugin layers, etc.