WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
83246
Make CSSValueID's into an enum instead of a collection of integers.
https://bugs.webkit.org/show_bug.cgi?id=83246
Summary
Make CSSValueID's into an enum instead of a collection of integers.
Luke Macpherson
Reported
2012-04-04 21:04:57 PDT
Make CSSValueID's into an enum instead of a collection of integers.
Attachments
Patch
(1.77 KB, patch)
2012-04-04 21:06 PDT
,
Luke Macpherson
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Luke Macpherson
Comment 1
2012-04-04 21:06:49 PDT
Created
attachment 135753
[details]
Patch
Luke Macpherson
Comment 2
2012-04-09 16:14:12 PDT
I'm just going to keep adding reviewers until someone does it.
WebKit Review Bot
Comment 3
2012-04-09 16:59:12 PDT
Comment on
attachment 135753
[details]
Patch Clearing flags on attachment: 135753 Committed
r113643
: <
http://trac.webkit.org/changeset/113643
>
WebKit Review Bot
Comment 4
2012-04-09 16:59:17 PDT
All reviewed patches have been landed. Closing bug.
Alexis Menard (darktears)
Comment 5
2012-04-10 04:31:04 PDT
Comment on
attachment 135753
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=135753&action=review
> Source/WebCore/ChangeLog:9 > + Follow-up patches will then convert existing code that uses integers to use the new enum.
Don't forget to patch RenderStyle.h systemFont and systemColor for all ports :).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug