Bug 83244 - [mac] WKTR should always keep its windows offscreen
Summary: [mac] WKTR should always keep its windows offscreen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks: 81965
  Show dependency tree / graph
 
Reported: 2012-04-04 19:46 PDT by Tim Horton
Modified: 2012-06-08 15:48 PDT (History)
5 users (show)

See Also:

Attachments
patch (2.80 KB, patch)
2012-04-04 19:59 PDT, Tim Horton 		simon.fraser: review+
simon.fraser: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2012-04-04 19:46:57 PDT 
Tests that use window.resize jump onto the main display. This is really annoying.

I have a patch.
Comment 1 Radar WebKit Bug Importer 2012-04-04 19:47:10 PDT 
<rdar://problem/11188764>
Comment 2 Tim Horton 2012-04-04 19:59:59 PDT 
Created attachment 135749 [details]
patch
Comment 3 Simon Fraser (smfr) 2012-04-04 20:16:32 PDT 
Comment on attachment 135749 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135749&action=review

> Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:79
> +    if(_shouldUseFakeOrigin)

Space after if.

> Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:83
> +    else
> +        return currentFrame;
> +}

No else after a return.
Comment 4 Tim Horton 2012-04-04 21:29:39 PDT 
(In reply to comment #3)
> (From update of attachment 135749 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135749&action=review
> 
> > Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:79
> > +    if(_shouldUseFakeOrigin)
> 
> Space after if.
> 
> > Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:83
> > +    else
> > +        return currentFrame;
> > +}
> 
> No else after a return.

Thanks!

Landed in http://trac.webkit.org/changeset/113288