RESOLVED FIXED 83225
[CMake] Do not pass -P to the preprocessor when running make_names.pl. 
https://bugs.webkit.org/show_bug.cgi?id=83225
Summary [CMake] Do not pass -P to the preprocessor when running make_names.pl.
Raphael Kubo da Costa (:rakuco)
Reported 2012-04-04 15:09:31 PDT
[CMake] Do not pass -P to the preprocessor in the common case.
Attachments
Patch (2.02 KB, patch)
2012-04-04 15:14 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
A hopefully better approach (3.96 KB, patch)
2012-04-05 18:43 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
A better approach, take 2 (3.70 KB, patch)
2012-04-09 16:58 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2012-04-04 15:14:44 PDT
Created attachment 135696 [details] Patch
Gyuyoung Kim
Comment 2 2012-04-04 18:09:42 PDT
Comment on attachment 135696 [details] Patch Attachment 135696 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12338025
Raphael Kubo da Costa (:rakuco)
Comment 3 2012-04-04 21:55:24 PDT
Comment on attachment 135696 [details] Patch Removing flags for now; this needs more thought in order not to break generate-bindings and the regexes in IDLStructure.pm.
Patrick R. Gansterer
Comment 4 2012-04-04 23:11:27 PDT
Why do you want to remove the flag?
Patrick R. Gansterer
Comment 5 2012-04-04 23:13:17 PDT
(In reply to comment #4) > Why do you want to remove the flag? Sorry, ChangeLog explains it already. ;-)
Raphael Kubo da Costa (:rakuco)
Comment 6 2012-04-05 18:43:41 PDT
Created attachment 135961 [details] A hopefully better approach
Patrick R. Gansterer
Comment 7 2012-04-06 02:54:50 PDT
Comment on attachment 135961 [details] A hopefully better approach if you really need to split up, i'd like to see that code only on one place (OptionsCommon.cmake) IMHO it would be clearer to define CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS for all compilers, so we can use it in WebKitMacros.cmake directly.
Raphael Kubo da Costa (:rakuco)
Comment 8 2012-04-06 04:27:54 PDT
(In reply to comment #7) > (From update of attachment 135961 [details]) > if you really need to split up, i'd like to see that code only on one place (OptionsCommon.cmake) IMHO it would be clearer to define CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS for all compilers, so we can use it in WebKitMacros.cmake directly. At first I thought of making it have the same value as CODE_GENERATOR_PREPROCESSOR for MSVC and QNX. Is that what you mean?
Patrick R. Gansterer
Comment 9 2012-04-06 08:00:18 PDT
(In reply to comment #8) > (In reply to comment #7) > > (From update of attachment 135961 [details] [details]) > > if you really need to split up, i'd like to see that code only on one place (OptionsCommon.cmake) IMHO it would be clearer to define CODE_GENERATOR_PREPROCESSOR_WITH_LINEMARKERS for all compilers, so we can use it in WebKitMacros.cmake directly. > > At first I thought of making it have the same value as CODE_GENERATOR_PREPROCESSOR for MSVC and QNX. Is that what you mean? yes
Raphael Kubo da Costa (:rakuco)
Comment 10 2012-04-09 16:58:37 PDT
Created attachment 136346 [details] A better approach, take 2
Rob Buis
Comment 11 2012-04-10 15:46:51 PDT
Comment on attachment 136346 [details] A better approach, take 2 Looks good.
Raphael Kubo da Costa (:rakuco)
Comment 12 2012-04-10 15:59:16 PDT
Comment on attachment 136346 [details] A better approach, take 2 Clearing flags on attachment: 136346 Committed r113786: <http://trac.webkit.org/changeset/113786>
Raphael Kubo da Costa (:rakuco)
Comment 13 2012-04-10 15:59:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.