Bug 83221 – IndexedDB: Support string.length in keyPaths

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Joshua Bell]

IndexedDB: Support string.length in keyPaths

[Joshua Bell]

Created attachment 135688 [details]
Patch

[Joshua Bell]

The spec sayeth:

Key path values can only be accessed from properties explicitly copied by the structured clone algorithm, as well as the following properties:

Blob.size
Blob.type
File.name
File.lastModifiedDate
Array.length
String.length

Array.length "just works", File/Blob are not yet supported. String.length needs a special case.

[Kentaro Hara]

Comment on attachment 135688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135688&action=review

> Source/WebCore/ChangeLog:6
> +        Special case in the IDB spec - keyPaths can reference the |length| property

Would you please add the link to the spec?

[Joshua Bell]

(In reply to comment #3)
> Would you please add the link to the spec?

http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#key-path-construct

[Kentaro Hara]

(In reply to comment #4)
> (In reply to comment #3)
> > Would you please add the link to the spec?
> 
> http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#key-path-construct

Thanks, I meant, it would be better to include the link in ChangeLog.

[Joshua Bell]

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Would you please add the link to the spec?
> > 
> > http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#key-path-construct
> 
> Thanks, I meant, it would be better to include the link in ChangeLog.

:) Will do.

[Joshua Bell]

Created attachment 135930 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 135930 [details]
Patch for landing

Clearing flags on attachment: 135930

Committed r113395: <http://trac.webkit.org/changeset/113395>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.