Bug 83212 – [CSS] Make makevalues.pl and makeprop.pl ignore '#'s.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Raphael Kubo da Costa (:rakuco)]

[CSS] Make makevalues.pl and makeprop.pl ignore '#'s.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 135673 [details]
Patch

[Tony Chang]

By this point, haven't we already run the .in files through the preprocessor and the preprocessor already handled the lines beginning with # (e.g., #if/#endif).  What's an example of a line starting with # that makes it through the preprocessor?

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #2)
> What's an example of a line starting with # that makes it through the preprocessor?

The ones produced by the preprocessor when -P is not passed to it:

# 1 "/home/rakuco/dev/webkit/WebKit/Source/WebCore/html/HTMLTagNames.in"
# 1 "<command-line>"
# 1 "/home/rakuco/dev/webkit/WebKit/Source/WebCore/html/HTMLTagNames.in"

etc

[Raphael Kubo da Costa (:rakuco)]

Just in case I wasn't clear enough: this patch is a side-effect of my intentions to make the CMake-based ports work with GCC 4.7 without changing the parameters currently passed to the preprocessor. "-P" is always being passed to the preprocessor, but this breaks dom/make_names.pl due to GCC not outputting empty lines with "-P" anymore; if I switch to never passing "-P" (my aim), the CSS scripts currently break because of the additional lines output by the preprocessor.

[Tony Chang]

I see, your plan is to remove -P in preprocessor.pm because -P causes you to lose empty lines which are needed by make_names.pl and InFilesParser.pm.  This wasn't clear to me in the ChangeLog description.

Would it be possible to have applyPreprocessor take a flag for whether it wants -P or not?  Or more generally, maybe applyPreprocessor can take an optional argument that is flags to pass to gcc.  If the argument is omitted, it adds "-E -P -x c++".

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #5)
> I see, your plan is to remove -P in preprocessor.pm because -P causes you to lose empty lines which are needed by make_names.pl and InFilesParser.pm.  This wasn't clear to me in the ChangeLog description.
> 
> Would it be possible to have applyPreprocessor take a flag for whether it wants -P or not?  Or more generally, maybe applyPreprocessor can take an optional argument that is flags to pass to gcc.  If the argument is omitted, it adds "-E -P -x c++".

Actually, my plan is to remote -P from Source/cmake/OptionsCommon.cmake; the CMake-based ports always pass --preprocessor to the scripts, so the defaults aren't used.

[Raphael Kubo da Costa (:rakuco)]

s/remote/remove/

[Tony Chang]

Comment on attachment 135673 [details]
Patch

Ok, seems fine.  I would rewrite the ChangeLog to be what you said in comment #4.

[Raphael Kubo da Costa (:rakuco)]

Created attachment 135692 [details]
Patch for landing

[Raphael Kubo da Costa (:rakuco)]

Committed r113244: <http://trac.webkit.org/changeset/113244>