Bug 83177 - [Chromium] TestWebKitAPI links in WebCore twice
Summary: [Chromium] TestWebKitAPI links in WebCore twice
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-04 10:17 PDT by Adam Barth
Modified: 2012-04-04 22:58 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.67 KB, patch)
2012-04-04 10:19 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (2.21 KB, patch)
2012-04-04 11:08 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-04-04 10:17:36 PDT 
[Chromium] TestWebKitAPI links in WebCore twice
Comment 1 Adam Barth 2012-04-04 10:19:13 PDT 
Created attachment 135619 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2012-04-04 10:28:08 PDT 
Comment on attachment 135619 [details]
Patch

Interesting. As an aside -- this executable is never run of any bots. Should we feel bothered about this?
Comment 3 Dimitri Glazkov (Google) 2012-04-04 10:40:00 PDT 
Oh, forgot! Can you add it back to build as a target in All.gyp?
Comment 4 Adam Barth 2012-04-04 10:42:32 PDT 
> All.gyp?

That's in Chromium-land, right?  I'll take care of adding it back once the roll happens.
Comment 5 Adam Barth 2012-04-04 10:43:16 PDT 
> Interesting. As an aside -- this executable is never run of any bots. Should we feel bothered about this?

Seems like we should run it on the same bots that run webkit_unit_tests, or we should fold it into webkit_unit_tests.
Comment 6 Dimitri Glazkov (Google) 2012-04-04 10:44:14 PDT 
No, that's Source/WebKit/chromium/All.gyp. I removed it here: http://trac.webkit.org/changeset/113201
Comment 7 Adam Barth 2012-04-04 11:08:44 PDT 
Created attachment 135631 [details]
Patch for landing
Comment 8 Dirk Pranke 2012-04-04 12:07:10 PDT 
(In reply to comment #5)
> > Interesting. As an aside -- this executable is never run of any bots. Should we feel bothered about this?
> 
> Seems like we should run it on the same bots that run webkit_unit_tests, or we should fold it into webkit_unit_tests.

Yes ... this is run on the build.webkit.org bots (run-api-tests), but we should probably be running them on the canaries as well.
Comment 9 WebKit Review Bot 2012-04-04 13:28:02 PDT 
Comment on attachment 135631 [details]
Patch for landing

Clearing flags on attachment: 135631

Committed r113231: <http://trac.webkit.org/changeset/113231>
Comment 10 WebKit Review Bot 2012-04-04 13:28:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 David Levin 2012-04-04 22:58:07 PDT 
(In reply to comment #5)
> > Interesting. As an aside -- this executable is never run of any bots. Should we feel bothered about this?
> 
> Seems like we should run it on the same bots that run webkit_unit_tests, or we should fold it into webkit_unit_tests.

Ideally webkit_unit_tests and this would be combined.

I think folding webkit_unit_tests into this would be ideal.