Bug 83169 - Update LayoutUnit usage in RenderInputSpeech::paintInputFieldSpeechButton
Summary: Update LayoutUnit usage in RenderInputSpeech::paintInputFieldSpeechButton
Status: RESOLVED DUPLICATE of bug 83089
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
Depends on:
Blocks: 60318
  Show dependency treegraph
Reported: 2012-04-04 09:05 PDT by Levi Weintraub
Modified: 2012-04-05 06:33 PDT (History)
5 users (show)

See Also:

Patch (3.49 KB, patch)
2012-04-04 09:48 PDT, Levi Weintraub
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch2 (3.49 KB, patch)
2012-04-04 10:59 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-04-04 09:05:12 PDT
Called from RenderTheme code, and therefor with an IntRect, we need to make sure we handle variables from the render tree properly.
Comment 1 Levi Weintraub 2012-04-04 09:48:36 PDT
Created attachment 135613 [details]

Not yet requesting a review since this isn't enabled on Apple's Mac port. I want to see this pass the Chromium EWS bot to ensure the refactoring is correct first.
Comment 2 WebKit Review Bot 2012-04-04 10:52:41 PDT
Comment on attachment 135613 [details]

Attachment 135613 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12320971
Comment 3 Levi Weintraub 2012-04-04 10:59:54 PDT
Created attachment 135628 [details]

Now with 100% fewer compiler errors?
Comment 4 Levi Weintraub 2012-04-05 06:33:20 PDT
My patch had some refactoring, but the main issue is resolved.

*** This bug has been marked as a duplicate of bug 83089 ***