Add WTF::getCurrentLocalTime()
Created attachment 135593 [details] Patch
Comment on attachment 135593 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135593&action=review > Source/WTF/ChangeLog:13 > + (WTF): Please always remove useless gunk like this. > Source/WTF/wtf/CurrentTime.h:61 > +inline void getCurrentLocalTime(struct tm* localTM) Why does this need to be inline? It most likely shouldn't be. > Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp:148 > + String dateString = makeRFC2822DateString(localTM.tm_wday, localTM.tm_mday, localTM.tm_mon, 1900 + localTM.tm_year, localTM.tm_hour, localTM.tm_min, localTM.tm_sec, calculateUTCOffset() / (1000 * 60)); It's not great that conversion to local time and time zone offset calculation are separate steps, subject to race condition. But not new to this patch, and not very likely to occur in practice.
Created attachment 135622 [details] Patch
Comment on attachment 135622 [details] Patch Attachment 135622 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/12323882
Created attachment 135640 [details] Patch
Comment on attachment 135640 [details] Patch Attachment 135640 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12324902
Created attachment 135672 [details] Patch
Comment on attachment 135672 [details] Patch Clearing flags on attachment: 135672 Committed r113295: <http://trac.webkit.org/changeset/113295>
All reviewed patches have been landed. Closing bug.