Bug 83163 - [EFL] [DRT] LayoutTestController needs implementation of setXSSAuditorEnabled
: [EFL] [DRT] LayoutTestController needs implementation of setXSSAuditorEnabled
Status: RESOLVED DUPLICATE of bug 83281
: WebKit
WebKit EFL
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-04-04 08:01 PST by
Modified: 2012-04-17 11:47 PST (History)


Attachments
Patch (5.45 KB, patch)
2012-04-04 09:11 PST, Sudarsana Nagineni (babu)
no flags Review Patch | Details | Formatted Diff | Diff
Patch (2.79 KB, patch)
2012-04-05 12:35 PST, Sudarsana Nagineni (babu)
gyuyoung.kim: commit‑queue-
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-04 08:01:44 PST
LayoutTestController needs implementation of setXSSAuditorEnabled in order to unskip tests in http/tests/security/xssAuditor.
------- Comment #1 From 2012-04-04 09:11:28 PST -------
Created an attachment (id=135607) [details]
Patch

DRT support for setXSSAuditorEnabled
------- Comment #2 From 2012-04-04 09:24:34 PST -------
(From update of attachment 135607 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=135607&action=review

> LayoutTests/platform/efl/Skipped:449
> +# EFL's LayoutTestController does not implement setCanOpenWindows and setCloseRemainingWindowsWhenComplete

These methods are implemented in LTC itself, not in the port's subclass.

> LayoutTests/platform/efl/Skipped:451
> +# EFL's LayoutTestController does not implement dumpFrameLoadCallbacks

You might want to coordinate with Christoph here, as he's working on unskipping tests related to this.
------- Comment #3 From 2012-04-04 09:25:14 PST -------
What does the XSS auditor do? Is it something that would be useful to expose publicly?
------- Comment #4 From 2012-04-05 03:42:01 PST -------
(In reply to comment #2)

Thanks for review.
> > LayoutTests/platform/efl/Skipped:449
> > +# EFL's LayoutTestController does not implement setCanOpenWindows and setCloseRemainingWindowsWhenComplete
> 
Okay. This test can be unskipped by enabling XSSAuditor by default when new window is opened.

> These methods are implemented in LTC itself, not in the port's subclass.
> 
> > LayoutTests/platform/efl/Skipped:451
> > +# EFL's LayoutTestController does not implement dumpFrameLoadCallbacks
> 
> You might want to coordinate with Christoph here, as he's working on unskipping tests related to this.

Chris patch doesn't fully fix this test. FrameLoaderClientEfl::didDetectXSS implementation also needed in order to unskip this test. I will update the description.
------- Comment #5 From 2012-04-05 03:54:58 PST -------
(In reply to comment #3)
> What does the XSS auditor do? 
It provides protection from reflected XSS attacks of malicious websites.

> Is it something that would be useful to expose publicly?
Yes, good to expose this pref to users. I will create a new bug and implement set/get APIs for this setting.
------- Comment #6 From 2012-04-05 12:35:15 PST -------
Created an attachment (id=135878) [details]
Patch

Use ewk API to enable the setting
------- Comment #7 From 2012-04-05 12:47:08 PST -------
(From update of attachment 135878 [details])
Attachment 135878 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12264454
------- Comment #8 From 2012-04-05 20:37:58 PST -------
(From update of attachment 135878 [details])
Clearing r? flag because you should submit this patch again after landing a patch of Bug 83281
------- Comment #9 From 2012-04-17 11:47:22 PST -------
As mentioned in bug #83281 and discussed on #webkit-efl, implemented everything together in bug #83281.

*** This bug has been marked as a duplicate of bug 83281 ***