WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
83162
Web Inspector: migrate from InspectorFrontendHost.saveAs to InspectorFrontendHost.save.
https://bugs.webkit.org/show_bug.cgi?id=83162
Summary
Web Inspector: migrate from InspectorFrontendHost.saveAs to InspectorFrontend...
Pavel Feldman
Reported
2012-04-04 08:01:41 PDT
This allows not showing save-as dialog for every content commit, but only for the new files edited / saved.
Attachments
Patch
(25.21 KB, patch)
2012-04-04 08:11 PDT
,
Pavel Feldman
yurys
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2012-04-04 08:11:31 PDT
Created
attachment 135592
[details]
Patch
WebKit Review Bot
Comment 2
2012-04-04 08:14:15 PDT
Please wait for approval from
abarth@webkit.org
,
dglazkov@chromium.org
,
fishd@chromium.org
,
jamesr@chromium.org
or
tkent@chromium.org
before submitting, as this patch contains changes to the Chromium public API. See also
https://trac.webkit.org/wiki/ChromiumWebKitAPI
.
Yury Semikhatsky
Comment 3
2012-04-04 08:28:47 PDT
Comment on
attachment 135592
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=135592&action=review
> Source/WebCore/ChangeLog:8 > + This change adds Save item into the context manus for inspector. It also makes
typo: manus -> menus
> Source/WebCore/inspector/InspectorFrontendClient.h:63 > + virtual void save(const WTF::String& url, const WTF::String& content, bool saveAs) = 0;
saveAs -> forceSaveAs
Pavel Feldman
Comment 4
2012-04-04 08:49:59 PDT
Committed
r113192
: <
http://trac.webkit.org/changeset/113192
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug