Bug 83162 - Web Inspector: migrate from InspectorFrontendHost.saveAs to InspectorFrontendHost.save.
Summary: Web Inspector: migrate from InspectorFrontendHost.saveAs to InspectorFrontend...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2012-04-04 08:01 PDT by Pavel Feldman
Modified: 2012-04-04 08:49 PDT (History)
16 users (show)

See Also:

Patch (25.21 KB, patch)
2012-04-04 08:11 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-04-04 08:01:41 PDT
This allows not showing save-as dialog for every content commit, but only for the new files edited / saved.
Comment 1 Pavel Feldman 2012-04-04 08:11:31 PDT
Created attachment 135592 [details]
Comment 2 WebKit Review Bot 2012-04-04 08:14:15 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Yury Semikhatsky 2012-04-04 08:28:47 PDT
Comment on attachment 135592 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=135592&action=review

> Source/WebCore/ChangeLog:8
> +        This change adds Save item into the context manus for inspector. It also makes

typo: manus -> menus

> Source/WebCore/inspector/InspectorFrontendClient.h:63
> +    virtual void save(const WTF::String& url, const WTF::String& content, bool saveAs) = 0;

saveAs -> forceSaveAs
Comment 4 Pavel Feldman 2012-04-04 08:49:59 PDT
Committed r113192: <http://trac.webkit.org/changeset/113192>