Bug 83157 - RenderTable should layout captions using LayoutUnits
Summary: RenderTable should layout captions using LayoutUnits
Status: RESOLVED DUPLICATE of bug 83089
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
Depends on:
Blocks: 60318
  Show dependency treegraph
Reported: 2012-04-04 06:35 PDT by Levi Weintraub
Modified: 2012-04-05 04:57 PDT (History)
4 users (show)

See Also:

Patch (2.51 KB, patch)
2012-04-04 06:50 PDT, Levi Weintraub
jchaffraix: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2012-04-04 06:35:09 PDT
Currently it's still using integers (yuck!)
Comment 1 Levi Weintraub 2012-04-04 06:50:01 PDT
Created attachment 135582 [details]
Comment 2 Levi Weintraub 2012-04-05 04:19:23 PDT
Comment on attachment 135582 [details]

Comment 3 WebKit Review Bot 2012-04-05 04:52:17 PDT
Comment on attachment 135582 [details]

Rejecting attachment 135582 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/rendering/RenderTable.cpp
Hunk #1 FAILED at 282.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderTable.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Julien Cha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12340280
Comment 4 Levi Weintraub 2012-04-05 04:57:25 PDT
Appears that Emil and I are stepping on each others toes :-/

*** This bug has been marked as a duplicate of bug 83089 ***