Bug 83137 - [GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC
Summary: [GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 58443
  Show dependency treegraph
 
Reported: 2012-04-04 03:34 PDT by ChangSeok Oh
Modified: 2012-04-05 02:25 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.94 KB, patch)
2012-04-05 00:16 PDT, ChangSeok Oh
no flags Details | Formatted Diff | Diff
Patch (2.41 KB, patch)
2012-04-05 01:45 PDT, ChangSeok Oh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2012-04-04 03:34:19 PDT
This is the bug to fix the failure for fast/filesystem/flags-passing.html
Comment 1 ChangSeok Oh 2012-04-04 20:11:35 PDT
The error message is like that...
CONSOLE MESSAGE: line 27: TypeError: 'undefined' is not a function (evaluating 'this[testsList[testCounter++]]()')
FAIL: Timed out waiting for notifyDone to be called
Comment 2 ChangSeok Oh 2012-04-05 00:16:27 PDT
Created attachment 135768 [details]
Patch
Comment 3 Kentaro Hara 2012-04-05 00:52:26 PDT
Comment on attachment 135768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135768&action=review

> LayoutTests/fast/filesystem/script-tests/flags-passing.js:27
> +        window[testsList[testCounter++]]();

The change looks OK, but we can simplify the code more, like this:

var testsList = [runObjectTest, cleanupAndRunNext, ...];  // An array of functions (not function names)

... else {
  (testsList[testCounter++])();
}
Comment 4 ChangSeok Oh 2012-04-05 01:45:09 PDT
Created attachment 135781 [details]
Patch
Comment 5 ChangSeok Oh 2012-04-05 01:46:00 PDT
Comment on attachment 135768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135768&action=review

Thanks for the review!

>> LayoutTests/fast/filesystem/script-tests/flags-passing.js:27
>> +        window[testsList[testCounter++]]();
> 
> The change looks OK, but we can simplify the code more, like this:
> 
> var testsList = [runObjectTest, cleanupAndRunNext, ...];  // An array of functions (not function names)
> 
> ... else {
>   (testsList[testCounter++])();
> }

Done. :)
Comment 6 Kentaro Hara 2012-04-05 01:46:06 PDT
Comment on attachment 135781 [details]
Patch

Looks OK. Thanks for fixing the bug!
Comment 7 WebKit Review Bot 2012-04-05 02:25:35 PDT
Comment on attachment 135781 [details]
Patch

Clearing flags on attachment: 135781

Committed r113305: <http://trac.webkit.org/changeset/113305>
Comment 8 WebKit Review Bot 2012-04-05 02:25:40 PDT
All reviewed patches have been landed.  Closing bug.