Bug 83137 – [GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[ChangSeok Oh]

This is the bug to fix the failure for fast/filesystem/flags-passing.html

[ChangSeok Oh]

The error message is like that...
CONSOLE MESSAGE: line 27: TypeError: 'undefined' is not a function (evaluating 'this[testsList[testCounter++]]()')
FAIL: Timed out waiting for notifyDone to be called

[ChangSeok Oh]

Created attachment 135768 [details]
Patch

[Kentaro Hara]

Comment on attachment 135768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135768&action=review

> LayoutTests/fast/filesystem/script-tests/flags-passing.js:27
> +        window[testsList[testCounter++]]();

The change looks OK, but we can simplify the code more, like this:

var testsList = [runObjectTest, cleanupAndRunNext, ...];  // An array of functions (not function names)

... else {
  (testsList[testCounter++])();
}

[ChangSeok Oh]

Created attachment 135781 [details]
Patch

[ChangSeok Oh]

Comment on attachment 135768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135768&action=review

Thanks for the review!

>> LayoutTests/fast/filesystem/script-tests/flags-passing.js:27
>> +        window[testsList[testCounter++]]();
> 
> The change looks OK, but we can simplify the code more, like this:
> 
> var testsList = [runObjectTest, cleanupAndRunNext, ...];  // An array of functions (not function names)
> 
> ... else {
>   (testsList[testCounter++])();
> }

Done. :)

[Kentaro Hara]

Comment on attachment 135781 [details]
Patch

Looks OK. Thanks for fixing the bug!

[WebKit Review Bot]

Comment on attachment 135781 [details]
Patch

Clearing flags on attachment: 135781

Committed r113305: <http://trac.webkit.org/changeset/113305>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.