Bug 83131 - [BlackBerry] Force compositing mode when backing store is not active
Summary: [BlackBerry] Force compositing mode when backing store is not active
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-04 02:09 PDT by Arvid Nilsson
Modified: 2012-04-05 08:57 PDT (History)
6 users (show)

See Also:

Attachments
Patch (39.37 KB, patch)
2012-04-04 02:39 PDT, Arvid Nilsson 		no flags Details | Formatted Diff | Diff
Patch (39.42 KB, patch)
2012-04-05 04:18 PDT, Arvid Nilsson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arvid Nilsson 2012-04-04 02:09:56 PDT 
Normally, we'd resort to direct rendering when the backing store is not active. However, direct rendering is broken with OpenGL compositing code path, and we have a better option anyway - use accelerated compositing layer to render the root layer instead of backing store. This will give us a tiled layer backing the root layer.

This in turn will enable multiple web pages to be composited at once with the new WebPageCompositor API.
Comment 1 Arvid Nilsson 2012-04-04 02:39:50 PDT 
Created attachment 135536 [details]
Patch
Comment 2 Arvid Nilsson 2012-04-04 02:41:05 PDT 
I think this patch could use an internal reviewer as well as an external, since I think this is not Antonio or Rob's area of expertise. But you're certainly welcome to do it if you feel up to the task =)
Comment 3 Filip Spacek 2012-04-04 13:10:04 PDT 
The patch looks great to me
Comment 4 Arvid Nilsson 2012-04-05 04:18:48 PDT 
Created attachment 135800 [details]
Patch
Comment 5 Arvid Nilsson 2012-04-05 04:19:39 PDT 
(In reply to comment #4)
> Created an attachment (id=135800) [details]
> Patch

ChangeLog entry updated with the fact that it was reviewed internally by Filip Spacek. Ready for external review =)
Comment 6 George Staikos 2012-04-05 05:41:32 PDT 
Comment on attachment 135800 [details]
Patch

Second r+!
Comment 7 Arvid Nilsson 2012-04-05 08:10:05 PDT 
Comment on attachment 135800 [details]
Patch

This can be landed indepently of the webcore patch we're depending on. I'll just remove the dependency.
Comment 8 WebKit Review Bot 2012-04-05 08:57:27 PDT 
Comment on attachment 135800 [details]
Patch

Clearing flags on attachment: 135800

Committed r113325: <http://trac.webkit.org/changeset/113325>
Comment 9 WebKit Review Bot 2012-04-05 08:57:32 PDT 
All reviewed patches have been landed.  Closing bug.