WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 83131
[BlackBerry] Force compositing mode when backing store is not active
https://bugs.webkit.org/show_bug.cgi?id=83131
Summary
[BlackBerry] Force compositing mode when backing store is not active
Arvid Nilsson
Reported
2012-04-04 02:09:56 PDT
Normally, we'd resort to direct rendering when the backing store is not active. However, direct rendering is broken with OpenGL compositing code path, and we have a better option anyway - use accelerated compositing layer to render the root layer instead of backing store. This will give us a tiled layer backing the root layer. This in turn will enable multiple web pages to be composited at once with the new WebPageCompositor API.
Attachments
Patch
(39.37 KB, patch)
2012-04-04 02:39 PDT
,
Arvid Nilsson
no flags
Details
Formatted Diff
Diff
Patch
(39.42 KB, patch)
2012-04-05 04:18 PDT
,
Arvid Nilsson
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Arvid Nilsson
Comment 1
2012-04-04 02:39:50 PDT
Created
attachment 135536
[details]
Patch
Arvid Nilsson
Comment 2
2012-04-04 02:41:05 PDT
I think this patch could use an internal reviewer as well as an external, since I think this is not Antonio or Rob's area of expertise. But you're certainly welcome to do it if you feel up to the task =)
Filip Spacek
Comment 3
2012-04-04 13:10:04 PDT
The patch looks great to me
Arvid Nilsson
Comment 4
2012-04-05 04:18:48 PDT
Created
attachment 135800
[details]
Patch
Arvid Nilsson
Comment 5
2012-04-05 04:19:39 PDT
(In reply to
comment #4
)
> Created an attachment (id=135800) [details] > Patch
ChangeLog entry updated with the fact that it was reviewed internally by Filip Spacek. Ready for external review =)
George Staikos
Comment 6
2012-04-05 05:41:32 PDT
Comment on
attachment 135800
[details]
Patch Second r+!
Arvid Nilsson
Comment 7
2012-04-05 08:10:05 PDT
Comment on
attachment 135800
[details]
Patch This can be landed indepently of the webcore patch we're depending on. I'll just remove the dependency.
WebKit Review Bot
Comment 8
2012-04-05 08:57:27 PDT
Comment on
attachment 135800
[details]
Patch Clearing flags on attachment: 135800 Committed
r113325
: <
http://trac.webkit.org/changeset/113325
>
WebKit Review Bot
Comment 9
2012-04-05 08:57:32 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug