RESOLVED FIXED Bug 83126
REGRESSION(r113149): for breaking Chromium builders (Requested by pfeldman on #webkit). 
https://bugs.webkit.org/show_bug.cgi?id=83126
Summary REGRESSION(r113149): for breaking Chromium builders (Requested by pfeldman on...
WebKit Review Bot
Reported 2012-04-04 01:55:37 PDT
http://trac.webkit.org/changeset/113149 broke the build: for breaking Chromium builders (Requested by pfeldman on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r113149 (53.66 KB, patch)
2012-04-04 01:56 PDT, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2012-04-04 01:56:11 PDT
Created attachment 135530 [details] ROLLOUT of r113149 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
WebKit Review Bot
Comment 2 2012-04-04 02:02:08 PDT
Comment on attachment 135530 [details] ROLLOUT of r113149 Clearing flags on attachment: 135530 Committed r113153: <http://trac.webkit.org/changeset/113153>
WebKit Review Bot
Comment 3 2012-04-04 02:02:12 PDT
All reviewed patches have been landed. Closing bug.
Hans Wennborg
Comment 4 2012-04-04 02:28:14 PDT
Note to self: this was the build failure: 13>e:\google-windows-1\chromium-win-release\build\source\webkit\chromium\public\platform\../../../../Platform/chromium/public/WebVector.h(84) : error C2228: left of '.size' must have class/struct/union 13> type is 'const unsigned long' 13> .\src\SpeechRecognitionClientProxy.cpp(57) : see reference to function template instantiation 'WebKit::WebVector<T>::WebVector<unsigned long>(const C &)' being compiled 13> with 13> [ 13> T=WebKit::WebSpeechGrammar, 13> C=unsigned long 13> ] 13>e:\google-windows-1\chromium-win-release\build\source\webkit\chromium\public\platform\../../../../Platform/chromium/public/WebVector.h(84) : error C2109: subscript requires array or pointer type 13>e:\google-windows-1\chromium-win-release\build\source\webkit\chromium\public\platform\../../../../Platform/chromium/public/WebVector.h(84) : error C2228: left of '.size' must have class/struct/union 13> type is 'const unsigned long'
Note You need to log in before you can comment on or make changes to this bug.