We used to pass client width to calculator's computeBarGraphWindowPosition(), then adjust for possible padding on the left. This often required passing paddingLeft along with the calculator and lead to possible inconsistent values of width used. Also, this makes it difficult to reuse position calculation logic for a single position, not the entire bar. This adds display window dimensions to calculator's state, so that it's sufficient to pass calculator around and trivial to implement position calculation for single time value.
Created attachment 135527 [details] Patch
Created attachment 135528 [details] Patch
Comment on attachment 135528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135528&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:735 > + this._minWidth = 5; Please use constants for these
Committed r113156: <http://trac.webkit.org/changeset/113156>
(In reply to comment #4) > Committed r113156: <http://trac.webkit.org/changeset/113156> This patch broke 4 inspector tests on GTK... http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r113156%20(21569)/results.html
(In reply to comment #5) > (In reply to comment #4) > > Committed r113156: <http://trac.webkit.org/changeset/113156> > > This patch broke 4 inspector tests on GTK... > http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r113156%20(21569)/results.html https://bugs.webkit.org/show_bug.cgi?id=83136
These tests are failing on Qt. After r113156. http://trac.webkit.org/changeset/113156 * http/tests/inspector/network/network-initiator-from-console.html Diff: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r113156%20(35808)/http/tests/inspector/network/network-initiator-from-console-diff.txt * http/tests/inspector/network/network-sidebar-width.html Diff: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r113156%20(35808)/http/tests/inspector/network/network-sidebar-width-diff.txt * http/tests/inspector/resource-har-pages.html Diff: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r113156%20(35808)/http/tests/inspector/resource-har-pages-diff.txt * inspector/debugger/source-frame.html Diff: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r113156%20(35808)/inspector/debugger/source-frame-diff.txt * inspector/debugger/watch-expressions-panel-switch.html Diff: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r113156%20(35808)/inspector/debugger/watch-expressions-panel-switch-diff.txt * inspector/network-status-non-http.html Diff: http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r113156%20(35808)/inspector/network-status-non-http-diff.txt I will skip these tests until It is fixed. Thanks for your investigation. Please unskip these tests if you have fixed it.
Committed r113177: <http://trac.webkit.org/changeset/113177>