Bug 83112 - Call histogramCustomCounts directly
Summary: Call histogramCustomCounts directly
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
Depends on:
Blocks: 82948
  Show dependency treegraph
Reported: 2012-04-03 20:22 PDT by Mark Pilgrim (Google)
Modified: 2012-04-04 12:46 PDT (History)
5 users (show)

See Also:

Patch (9.46 KB, patch)
2012-04-03 20:23 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff
Patch (9.05 KB, patch)
2012-04-04 06:46 PDT, Mark Pilgrim (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-04-03 20:22:47 PDT
Call histogramCustomCounts directly
Comment 1 Mark Pilgrim (Google) 2012-04-03 20:23:17 PDT
Created attachment 135497 [details]
Comment 2 James Robinson 2012-04-03 20:41:24 PDT
Comment on attachment 135497 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=135497&action=review

I'd like Adam to check that this is the intended use of WebKit::Platform, but if so then this looks all right

> Source/WebKit/chromium/src/painting/PaintAggregator.cpp:36
> +#include <public/Platform.h>

this seems spurious
Comment 3 Adam Barth 2012-04-03 21:23:24 PDT
Comment on attachment 135497 [details]

Yep.  Looks great.  Thanks.
Comment 4 Mark Pilgrim (Google) 2012-04-04 06:46:06 PDT
Created attachment 135581 [details]
Comment 5 Mark Pilgrim (Google) 2012-04-04 06:47:05 PDT
Removed spurious include in PaintAggregator.cpp.
Comment 6 WebKit Review Bot 2012-04-04 12:46:48 PDT
Comment on attachment 135581 [details]

Clearing flags on attachment: 135581

Committed r113227: <http://trac.webkit.org/changeset/113227>
Comment 7 WebKit Review Bot 2012-04-04 12:46:53 PDT
All reviewed patches have been landed.  Closing bug.