Bug 83109 – Followup to "Call incrementStatsCounter directly"

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mark Pilgrim (Google)]

Followup to "Call incrementStatsCounter directly"

[Mark Pilgrim (Google)]

Created attachment 135491 [details]
Patch

[Kentaro Hara]

Comment on attachment 135491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135491&action=review

> Source/WebCore/bindings/v8/V8Proxy.h:49
> +#define INC_STATS(name) PlatformSupport::incrementStatsCounter(name)

Sorry, I am a bit confused. You removed PlatformSupport::incrementStatsCounter in r113034, and thus PlatformSupport::incrementStatsCounter no longer exists... doesn't it?

[Adam Barth]

Comment on attachment 135491 [details]
Patch

Mark, you want to introduce an abstraction like <http://trac.webkit.org/browser/trunk/Source/WebCore/platform/HistogramSupport.h>, perhaps called StatsCounter.h.  We'll implement StatsCounterChromium.cpp via WebKit::Platform and other ports can implement StatsCounterWhatever.cpp however they like (if they want stats counting.

[Mark Pilgrim (Google)]

Created attachment 135681 [details]
Work-in-Progress Patch, please ignore

[Mark Pilgrim (Google)]

Comment on attachment 135681 [details]
Work-in-Progress Patch, please ignore

Not ready for review.

[Mark Pilgrim (Google)]

Created attachment 137680 [details]
Patch

[Build Bot]

Comment on attachment 137680 [details]
Patch

Attachment 137680 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12430074

[Mark Pilgrim (Google)]

Created attachment 137693 [details]
Patch

[Kentaro Hara]

Comment on attachment 137693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137693&action=review

OK

> Source/WebCore/platform/StatsCounter.h:38
> +    static void incrementStatsCounter(const char* counterName);

Nit: 'counterName' is not necessary.

[Kentaro Hara]

Comment on attachment 137693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=137693&action=review

>> Source/WebCore/platform/StatsCounter.h:38
>> +    static void incrementStatsCounter(const char* counterName);
> 
> Nit: 'counterName' is not necessary.

Would you please remove this before commit?

[Mark Pilgrim (Google)]

Created attachment 137703 [details]
Patch

[WebKit Review Bot]

Comment on attachment 137703 [details]
Patch

Clearing flags on attachment: 137703

Committed r114515: <http://trac.webkit.org/changeset/114515>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.