Followup to "Call incrementStatsCounter directly"
Created attachment 135491 [details] Patch
Comment on attachment 135491 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135491&action=review > Source/WebCore/bindings/v8/V8Proxy.h:49 > +#define INC_STATS(name) PlatformSupport::incrementStatsCounter(name) Sorry, I am a bit confused. You removed PlatformSupport::incrementStatsCounter in r113034, and thus PlatformSupport::incrementStatsCounter no longer exists... doesn't it?
Comment on attachment 135491 [details] Patch Mark, you want to introduce an abstraction like <http://trac.webkit.org/browser/trunk/Source/WebCore/platform/HistogramSupport.h>, perhaps called StatsCounter.h. We'll implement StatsCounterChromium.cpp via WebKit::Platform and other ports can implement StatsCounterWhatever.cpp however they like (if they want stats counting.
Created attachment 135681 [details] Work-in-Progress Patch, please ignore
Comment on attachment 135681 [details] Work-in-Progress Patch, please ignore Not ready for review.
Created attachment 137680 [details] Patch
Comment on attachment 137680 [details] Patch Attachment 137680 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12430074
Created attachment 137693 [details] Patch
Comment on attachment 137693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137693&action=review OK > Source/WebCore/platform/StatsCounter.h:38 > + static void incrementStatsCounter(const char* counterName); Nit: 'counterName' is not necessary.
Comment on attachment 137693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137693&action=review >> Source/WebCore/platform/StatsCounter.h:38 >> + static void incrementStatsCounter(const char* counterName); > > Nit: 'counterName' is not necessary. Would you please remove this before commit?
Created attachment 137703 [details] Patch
Comment on attachment 137703 [details] Patch Clearing flags on attachment: 137703 Committed r114515: <http://trac.webkit.org/changeset/114515>
All reviewed patches have been landed. Closing bug.