Bug 83098 - Offlineasm ARM backend uses the wrong mnemonic for multiply
Summary: Offlineasm ARM backend uses the wrong mnemonic for multiply
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2012-04-03 17:39 PDT by Filip Pizlo
Modified: 2012-04-03 17:52 PDT (History)
0 users

See Also:

the patch (1.63 KB, patch)
2012-04-03 17:42 PDT, Filip Pizlo
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-04-03 17:39:52 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2012-04-03 17:42:19 PDT
Created attachment 135469 [details]
the patch
Comment 2 Darin Adler 2012-04-03 17:43:59 PDT
Comment on attachment 135469 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135469&action=review

> Source/JavaScriptCore/offlineasm/armv7.rb:781
>              if operands.size == 2 or operands[0] == operands[2] or operands[1] == operands[2]
> -                emitArmV7("muls", operands)
> +                emitArmV7("mul", operands)

Taking your change log comment literally, it seems this should stay “muls” since it’s passing only two operands.

> Source/JavaScriptCore/offlineasm/armv7.rb:784
> -                $asm.puts "muls #{operands[2].armV7Operand}, #{operands[2].armV7Operand}, #{operands[1].armV7Operand}"
> +                $asm.puts "mul #{operands[2].armV7Operand}, #{operands[2].armV7Operand}, #{operands[1].armV7Operand}"

This change matches your change log comment.
Comment 3 Filip Pizlo 2012-04-03 17:52:53 PDT
Landed in http://trac.webkit.org/changeset/113113