WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
83085
[BlackBerry] Make the switch statement in WebPage::notifyAppActivationStateChange() stronger
https://bugs.webkit.org/show_bug.cgi?id=83085
Summary
[BlackBerry] Make the switch statement in WebPage::notifyAppActivationStateCh...
Rob Buis
Reported
2012-04-03 15:57:10 PDT
In WebPage::notifyAppActivationStateChange(), suggested by Dan Bates, we should get rid of the default case to force a compiler error instead of using a runtime error: for (; it != last; ++it) { switch (activationState) { case ActivationActive: (*it)->handleAppActivatedEvent(); break; case ActivationInactive: (*it)->handleAppDeactivatedEvent(); break; case ActivationStandby: (*it)->handleAppStandbyEvent(); break; default: ASSERT(0); break; } }
Attachments
Patch
(1.59 KB, patch)
2012-04-03 16:00 PDT
,
Rob Buis
tonikitoo
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Rob Buis
Comment 1
2012-04-03 16:00:56 PDT
Created
attachment 135443
[details]
Patch
Rob Buis
Comment 2
2012-04-04 14:54:58 PDT
Landed in
r113203
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug