Bug 83073 - Fix usage of LayoutUnits and snapping for scrolling in RenderBox
Summary: Fix usage of LayoutUnits and snapping for scrolling in RenderBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2012-04-03 14:34 PDT by Emil A Eklund
Modified: 2012-04-04 12:10 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.41 KB, patch)
2012-04-03 14:48 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-03 (6.53 MB, application/zip)
2012-04-03 16:35 PDT, WebKit Review Bot 		no flags Details
Patch (7.23 KB, patch)
2012-04-03 17:05 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-04-03 14:34:41 PDT 
Fix usage of LayoutUnits and snapping for scrolling in RenderBox
Comment 1 Emil A Eklund 2012-04-03 14:48:27 PDT 
Created attachment 135434 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-03 16:35:40 PDT 
Comment on attachment 135434 [details]
Patch

Attachment 135434 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12315008

New failing tests:
fast/dom/Element/scrollWidth.html
Comment 3 WebKit Review Bot 2012-04-03 16:35:46 PDT 
Created attachment 135453 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 Emil A Eklund 2012-04-03 17:05:47 PDT 
Created attachment 135461 [details]
Patch
Comment 5 Emil A Eklund 2012-04-03 17:13:41 PDT 
Turns out we do not snap the scrollWidth in RTL for a reason, had forgotten about that. Good thing we have great the test coverage for this code.
Comment 6 Eric Seidel (no email) 2012-04-03 19:08:35 PDT 
Comment on attachment 135461 [details]
Patch

OK.
Comment 7 WebKit Review Bot 2012-04-04 12:10:18 PDT 
Comment on attachment 135461 [details]
Patch

Clearing flags on attachment: 135461

Committed r113223: <http://trac.webkit.org/changeset/113223>
Comment 8 WebKit Review Bot 2012-04-04 12:10:32 PDT 
All reviewed patches have been landed.  Closing bug.