Bug 83066 - [chromium] Include Image.h in TextFieldDecoratorImpl.cpp
Summary: [chromium] Include Image.h in TextFieldDecoratorImpl.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: vollick
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-03 14:07 PDT by vollick
Modified: 2012-04-03 18:04 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.16 KB, patch)
2012-04-03 14:25 PDT, vollick 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description vollick 2012-04-03 14:07:40 PDT 
Build fix.
Comment 1 vollick 2012-04-03 14:25:59 PDT 
Created attachment 135428 [details]
Patch
Comment 2 James Robinson 2012-04-03 14:29:31 PDT 
What configuration has an error here?  Are there any bots that are broken (and if not, why?)
Comment 3 James Robinson 2012-04-03 14:31:24 PDT 
And what is the compile error?
Comment 4 James Robinson 2012-04-03 14:33:14 PDT 
Ah, do you have SVG disabled locally by any chance?  SVGImageCache.h has:

#if ENABLE(SVG)
#include "Image.h"
Comment 5 James Robinson 2012-04-03 14:42:37 PDT 
Comment on attachment 135428 [details]
Patch

R=me

compiling with disable_svg=1 means you're on your own, for the most part.
Comment 6 vollick 2012-04-03 17:31:23 PDT 
You're right -- I was compiling with disable_svg=1. I'll be sure to get rid of that gyp define.
Comment 7 WebKit Review Bot 2012-04-03 18:03:57 PDT 
Comment on attachment 135428 [details]
Patch

Clearing flags on attachment: 135428

Committed r113116: <http://trac.webkit.org/changeset/113116>
Comment 8 WebKit Review Bot 2012-04-03 18:04:01 PDT 
All reviewed patches have been landed.  Closing bug.