Bug 83065 - kill-old-processes should kill apache2 and httpd
Summary: kill-old-processes should kill apache2 and httpd
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-03 14:01 PDT by Ryosuke Niwa
Modified: 2012-04-04 12:52 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.40 KB, patch)
2012-04-03 14:02 PDT, Ryosuke Niwa
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-04-03 14:01:22 PDT
kill-old-processes should kill apache2 and httpd
Comment 1 Ryosuke Niwa 2012-04-03 14:02:39 PDT
Created attachment 135421 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-04-03 14:07:14 PDT
Comment on attachment 135421 [details]
Patch

seems OK.  Also seems like a hard way to bring down httpd, etc.  Also this would suck if you're tryign to run a http server on the same machine as a buildbot. :(
Comment 3 Ryosuke Niwa 2012-04-04 00:27:21 PDT
Committed in http://trac.webkit.org/changeset/113114.
Comment 4 Alexey Proskuryakov 2012-04-04 12:47:33 PDT
Does this mean that a machine with buildbots cannot have web sharing enabled?

What is apache2 and why does it need to be killed? 

This script is quite weird. In addition to "WebKitPluginAgen" without "t", there are mystery processes "Safari Web Content", "TestWebKitAPI Web Content", "WebKitTestRunner Web Content", which I don't think exist anywhere.
Comment 5 Alexey Proskuryakov 2012-04-04 12:48:57 PDT
"per5.12" and "Problem Reporter" are another mystery processes. What's going on here?
Comment 6 Dirk Pranke 2012-04-04 12:52:57 PDT
(In reply to comment #4)
> Does this mean that a machine with buildbots cannot have web sharing enabled?
> 

I believe with web sharing, httpd runs as root, so it wouldn't be killed and should be fine.

> What is apache2 and why does it need to be killed? 

apache2 is what most linux distros call httpd (httpd is reserved for apache 1.x), and what new-run-webkit-tests normally uses for the web server. The patch probably only needed httpd on the mac, since it doesn't ship w/ an apache2.