Bug 83062 - [Qt][WK2] Page loading status API lacks a status for intentionally stopped loading
Summary: [Qt][WK2] Page loading status API lacks a status for intentionally stopped lo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Marcelo Lira
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2012-04-03 13:28 PDT by Marcelo Lira
Modified: 2012-09-11 06:49 PDT (History)
8 users (show)

See Also:


Attachments
Patch (5.83 KB, patch)
2012-04-03 13:37 PDT, Marcelo Lira
no flags Details | Formatted Diff | Diff
fixed patch (5.83 KB, patch)
2012-04-03 14:04 PDT, Marcelo Lira
no flags Details | Formatted Diff | Diff
Patch (7.90 KB, patch)
2012-09-10 11:11 PDT, Marcelo Lira
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marcelo Lira 2012-04-03 13:28:11 PDT
Page loading status API lacks a status for intentionally stopped loading
Comment 1 Marcelo Lira 2012-04-03 13:37:08 PDT
Created attachment 135411 [details]
Patch
Comment 2 Alexis Menard (darktears) 2012-04-03 13:41:56 PDT
Comment on attachment 135411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135411&action=review

> Source/WebKit2/ChangeLog:9
> +        is set to the new state LoadStoppedStatus. This reflects reality more accuratelly,

typo : accurately

> Source/WebKit2/ChangeLog:10
> +        for the page was not fully loaded (a LoadSucceededStatus), and it wasn't an unexpected

The english has some issue here.
Comment 3 Marcelo Lira 2012-04-03 14:04:23 PDT
Created attachment 135422 [details]
fixed patch
Comment 4 Caio Marcelo de Oliveira Filho 2012-09-05 04:04:00 PDT
Marcelo: I think would be nice to have API tests for this. :-)

Simon, Tor-Arne: what do you think of this new status?
Comment 5 Tor Arne Vestbø 2012-09-05 04:25:31 PDT
Comment on attachment 135422 [details]
fixed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135422&action=review

lgtm

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:154
> +void QQuickWebViewPrivate::loadDidStopped()

This is a frankenstein of WebKit/Apple and Qt naming convention (did + 'ed) :)

I prefer we keep the Qt one here, loadStopped. Either that or loadDidStop.
Comment 6 Marcelo Lira 2012-09-10 11:11:06 PDT
Created attachment 163168 [details]
Patch
Comment 7 WebKit Review Bot 2012-09-11 06:49:08 PDT
Comment on attachment 163168 [details]
Patch

Clearing flags on attachment: 163168

Committed r128177: <http://trac.webkit.org/changeset/128177>
Comment 8 WebKit Review Bot 2012-09-11 06:49:11 PDT
All reviewed patches have been landed.  Closing bug.