RESOLVED FIXED Bug 83062
[Qt][WK2] Page loading status API lacks a status for intentionally stopped loading 
https://bugs.webkit.org/show_bug.cgi?id=83062
Summary [Qt][WK2] Page loading status API lacks a status for intentionally stopped lo...
Marcelo Lira
Reported 2012-04-03 13:28:11 PDT
Page loading status API lacks a status for intentionally stopped loading
Attachments
Patch (5.83 KB, patch)
2012-04-03 13:37 PDT, Marcelo Lira 		no flags
DetailsFormatted DiffDiff
fixed patch (5.83 KB, patch)
2012-04-03 14:04 PDT, Marcelo Lira 		no flags
DetailsFormatted DiffDiff
Patch (7.90 KB, patch)
2012-09-10 11:11 PDT, Marcelo Lira 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Marcelo Lira
Comment 1 2012-04-03 13:37:08 PDT
Created attachment 135411 [details] Patch
Alexis Menard (darktears)
Comment 2 2012-04-03 13:41:56 PDT
Comment on attachment 135411 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135411&action=review > Source/WebKit2/ChangeLog:9 > + is set to the new state LoadStoppedStatus. This reflects reality more accuratelly, typo : accurately > Source/WebKit2/ChangeLog:10 > + for the page was not fully loaded (a LoadSucceededStatus), and it wasn't an unexpected The english has some issue here.
Marcelo Lira
Comment 3 2012-04-03 14:04:23 PDT
Created attachment 135422 [details] fixed patch
Caio Marcelo de Oliveira Filho
Comment 4 2012-09-05 04:04:00 PDT
Marcelo: I think would be nice to have API tests for this. :-) Simon, Tor-Arne: what do you think of this new status?
Tor Arne Vestbø
Comment 5 2012-09-05 04:25:31 PDT
Comment on attachment 135422 [details] fixed patch View in context: https://bugs.webkit.org/attachment.cgi?id=135422&action=review lgtm > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:154 > +void QQuickWebViewPrivate::loadDidStopped() This is a frankenstein of WebKit/Apple and Qt naming convention (did + 'ed) :) I prefer we keep the Qt one here, loadStopped. Either that or loadDidStop.
Marcelo Lira
Comment 6 2012-09-10 11:11:06 PDT
Created attachment 163168 [details] Patch
WebKit Review Bot
Comment 7 2012-09-11 06:49:08 PDT
Comment on attachment 163168 [details] Patch Clearing flags on attachment: 163168 Committed r128177: <http://trac.webkit.org/changeset/128177>
WebKit Review Bot
Comment 8 2012-09-11 06:49:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.