Bug 83059 - [Chromium] transform-origin-css-property.xhtml is flaky
Summary: [Chromium] transform-origin-css-property.xhtml is flaky
Status: RESOLVED DUPLICATE of bug 84203
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Florin Malita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-03 13:04 PDT by Florin Malita
Modified: 2012-09-10 10:48 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.08 KB, patch)
2012-04-03 13:17 PDT, Florin Malita
zimmermann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florin Malita 2012-04-03 13:04:11 PDT
See 
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg%2Ftransforms%2Ftransform-origin-css-property.xhtml

Looks like the reference html produces sub-pixel artifacts. Maybe we can re-write it to avoid transformed divs.
Comment 1 Florin Malita 2012-04-03 13:17:31 PDT
Created attachment 135407 [details]
Patch
Comment 2 Eric Seidel (no email) 2012-05-21 15:17:07 PDT
Levi is likely your best reviewer here!
Comment 3 Levi Weintraub 2012-05-21 15:26:06 PDT
(In reply to comment #0)
> See 
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg%2Ftransforms%2Ftransform-origin-css-property.xhtml
> 
> Looks like the reference html produces sub-pixel artifacts. Maybe we can re-write it to avoid transformed divs.

The change looks fine, but have you verified that this eliminates the flakiness? run-webkit-tests has a -- iterations flag that could help you verify it.
Comment 4 Nikolas Zimmermann 2012-05-21 23:56:43 PDT
Comment on attachment 135407 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135407&action=review

Looks good to me as well, but please check as Levi suggested. If its fixed, r=me with following comments:

> LayoutTests/ChangeLog:9
> +        Refactored the reference to emultate rotation.

typo: emulate.

> LayoutTests/svg/transforms/transform-origin-css-property-expected.xhtml:30
> +            var x, y;

Indentation is off.
Comment 5 Florin Malita 2012-05-22 14:16:23 PDT
Thanks for reviewing, looks like this was already fixed here: https://bugs.webkit.org/show_bug.cgi?id=84203

*** This bug has been marked as a duplicate of bug 84203 ***