Bug 83059 – [Chromium] transform-origin-css-property.xhtml is flaky

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Tools / Tests

[Florin Malita]

See 
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg%2Ftransforms%2Ftransform-origin-css-property.xhtml

Looks like the reference html produces sub-pixel artifacts. Maybe we can re-write it to avoid transformed divs.

[Florin Malita]

Created attachment 135407 [details]
Patch

[Eric Seidel (no email)]

Levi is likely your best reviewer here!

[Levi Weintraub]

(In reply to comment #0)
> See 
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg%2Ftransforms%2Ftransform-origin-css-property.xhtml
> 
> Looks like the reference html produces sub-pixel artifacts. Maybe we can re-write it to avoid transformed divs.

The change looks fine, but have you verified that this eliminates the flakiness? run-webkit-tests has a -- iterations flag that could help you verify it.

[Nikolas Zimmermann]

Comment on attachment 135407 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135407&action=review

Looks good to me as well, but please check as Levi suggested. If its fixed, r=me with following comments:

> LayoutTests/ChangeLog:9
> +        Refactored the reference to emultate rotation.

typo: emulate.

> LayoutTests/svg/transforms/transform-origin-css-property-expected.xhtml:30
> +            var x, y;

Indentation is off.

[Florin Malita]

Thanks for reviewing, looks like this was already fixed here: https://bugs.webkit.org/show_bug.cgi?id=84203

*** This bug has been marked as a duplicate of bug 84203 ***