Bug 83022 - Web Inspector: [chromium] add provisional save method into the frontend client.
Summary: Web Inspector: [chromium] add provisional save method into the frontend client.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-03 06:04 PDT by Pavel Feldman
Modified: 2012-04-03 07:29 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2012-04-03 06:05 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-04-03 06:04:23 PDT
Patch to follow.
Comment 1 Pavel Feldman 2012-04-03 06:05:36 PDT
Created attachment 135318 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-03 06:07:40 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Yury Semikhatsky 2012-04-03 06:54:11 PDT
Comment on attachment 135318 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135318&action=review

> Source/WebKit/chromium/public/WebDevToolsFrontendClient.h:54
> +    virtual void save(const WebString& url, const WebString& content, bool saveAs) { }

I think we should pass defaultFileName as well.
Comment 4 Pavel Feldman 2012-04-03 07:29:48 PDT
Committed r113032: <http://trac.webkit.org/changeset/113032>