WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
83020
[EFL][DRT] FrameloaderClientEfl needs to handle media content correctly
https://bugs.webkit.org/show_bug.cgi?id=83020
Summary
[EFL][DRT] FrameloaderClientEfl needs to handle media content correctly
Dominik Röttsches (drott)
Reported
2012-04-03 05:13:20 PDT
FrameloaderClientEfl lacks handling for media content types (video/audio), leading to timeouts for example in http/tests/media/media-document.html.
Attachments
Fixing media content handling in FrameLoaderClientEfl
(7.26 KB, patch)
2012-04-03 06:58 PDT
,
Dominik Röttsches (drott)
no flags
Details
Formatted Diff
Diff
Fixing media content handling in FrameLoaderClientEfl, v2
(6.91 KB, patch)
2012-04-04 02:52 PDT
,
Dominik Röttsches (drott)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dominik Röttsches (drott)
Comment 1
2012-04-03 06:58:23 PDT
Created
attachment 135324
[details]
Fixing media content handling in FrameLoaderClientEfl Fixing media content handling, unskipping related cases.
Ryuan Choi
Comment 2
2012-04-04 01:22:23 PDT
Comment on
attachment 135324
[details]
Fixing media content handling in FrameLoaderClientEfl View in context:
https://bugs.webkit.org/attachment.cgi?id=135324&action=review
Basically Looks good to me.
> Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:789 > + WebKitErrorPluginWillHandleLoad = 203
Nit, WebKitErrorsPrivate.h define WebKitErrorPlugInWillHandleLoad as 204.
Dominik Röttsches (drott)
Comment 3
2012-04-04 02:52:36 PDT
Created
attachment 135537
[details]
Fixing media content handling in FrameLoaderClientEfl, v2 Addressing enum nit.
WebKit Review Bot
Comment 4
2012-04-04 05:44:02 PDT
Comment on
attachment 135537
[details]
Fixing media content handling in FrameLoaderClientEfl, v2 Clearing flags on attachment: 135537 Committed
r113178
: <
http://trac.webkit.org/changeset/113178
>
WebKit Review Bot
Comment 5
2012-04-04 05:44:07 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug