Bug 83013 - [chromium] Canvas2DLayerChromium::updateCompositorResources should flush after copying
Summary: [chromium] Canvas2DLayerChromium::updateCompositorResources should flush afte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sami Kyostila
URL: http://www.kevs3d.co.uk/dev/asteroids...
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-03 03:32 PDT by Sami Kyostila
Modified: 2012-04-03 07:50 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.25 KB, patch)
2012-04-03 05:13 PDT, Sami Kyostila 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sami Kyostila 2012-04-03 03:32:17 PDT 
Canvas2DLayerChromium::updateCompositorResources should issue a glFlush after copying the canvas back buffer texture to the front buffer. Otherwise the canvas may start rendering new context before the copy is performed, causing the copy to source from partially rendered data.

The flush was there previously but got mistakenly removed when the new TextureCopier utility was added.
Comment 1 Sami Kyostila 2012-04-03 05:13:26 PDT 
Created attachment 135313 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-03 07:50:19 PDT 
Comment on attachment 135313 [details]
Patch

Clearing flags on attachment: 135313

Committed r113033: <http://trac.webkit.org/changeset/113033>
Comment 3 WebKit Review Bot 2012-04-03 07:50:24 PDT 
All reviewed patches have been landed.  Closing bug.