Bug 83000 - REGRESSION(r80439): Crash in StylePropertySet::borderSpacingValue
Summary: REGRESSION(r80439): Crash in StylePropertySet::borderSpacingValue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 23:11 PDT by Ryosuke Niwa
Modified: 2012-04-03 09:52 PDT (History)
11 users (show)

See Also:

Attachments
Patch (4.20 KB, patch)
2012-04-02 23:52 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-04-02 23:11:55 PDT 
Reduction:

<!DOCTYPE html>
<body>
<script type="text/javascript">
a = document.createElement("a");
a.setAttribute("style", "-webkit-border-horizontal-spacing:1px;");
a.style.getPropertyValue('border-spacing');
</script>

http://crbug.com/121121
Comment 1 Ryosuke Niwa 2012-04-02 23:18:51 PDT 
Should specifying -webkit-border-horizontal-spacing also set -webkit-border-vertical-spacing to be consistent with the standard border-spacing property? (border-spacing doesn't allow only vertical spacing to be specified).
Comment 2 Ryosuke Niwa 2012-04-02 23:48:39 PDT 
I'm going to submit a patch assuming that the answer to my question in comment #2 is no (i.e. we want to allow websites specifying border-spacing-vertical without border-spacing-horizontal).
Comment 3 Ryosuke Niwa 2012-04-02 23:52:07 PDT 
Created attachment 135282 [details]
Patch
Comment 4 Andreas Kling 2012-04-03 04:35:17 PDT 
Comment on attachment 135282 [details]
Patch

Good find.
Comment 5 Andreas Kling 2012-04-03 04:36:16 PDT 
(In reply to comment #2)
> I'm going to submit a patch assuming that the answer to my question in comment #2 is no (i.e. we want to allow websites specifying border-spacing-vertical without border-spacing-horizontal).

r=me as is to fix the crash. This question still needs an answer though.
Comment 6 Ryosuke Niwa 2012-04-03 09:26:27 PDT 
I'm going to land this patch as is since we can always revert it if we want the other behavior instead.

(In reply to comment #5)
> (In reply to comment #2)
> > I'm going to submit a patch assuming that the answer to my question in comment #2 is no (i.e. we want to allow websites specifying border-spacing-vertical without border-spacing-horizontal).
> 
> r=me as is to fix the crash. This question still needs an answer though.

Yes, please someone answer my question...
Comment 7 WebKit Review Bot 2012-04-03 09:52:47 PDT 
Comment on attachment 135282 [details]
Patch

Clearing flags on attachment: 135282

Committed r113049: <http://trac.webkit.org/changeset/113049>
Comment 8 WebKit Review Bot 2012-04-03 09:52:52 PDT 
All reviewed patches have been landed.  Closing bug.