Bug 82977 - [Part 2] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
Summary: [Part 2] We should use CSSPropertyID rather than integers when manipulating C...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexis Menard (darktears)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 16:45 PDT by Alexis Menard (darktears)
Modified: 2012-04-04 06:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (93.67 KB, patch)
2012-04-02 16:53 PDT, Alexis Menard (darktears) 		no flags Details | Formatted Diff | Diff
Patch (93.13 KB, patch)
2012-04-02 18:06 PDT, Alexis Menard (darktears) 		no flags Details | Formatted Diff | Diff
Patch (93.88 KB, patch)
2012-04-03 05:39 PDT, Alexis Menard (darktears) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2012-04-02 16:45:19 PDT 
[Part 2] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
Comment 1 Alexis Menard (darktears) 2012-04-02 16:53:35 PDT 
Created attachment 135230 [details]
Patch
Comment 2 Build Bot 2012-04-02 17:22:43 PDT 
Comment on attachment 135230 [details]
Patch

Attachment 135230 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12309847
Comment 3 Alexis Menard (darktears) 2012-04-02 18:06:28 PDT 
Created attachment 135249 [details]
Patch

Rebased patch
Comment 4 Build Bot 2012-04-02 18:30:27 PDT 
Comment on attachment 135249 [details]
Patch

Attachment 135249 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12307910
Comment 5 Alexis Menard (darktears) 2012-04-03 05:39:30 PDT 
Created attachment 135314 [details]
Patch

Should fix the mac build
Comment 6 Andreas Kling 2012-04-03 05:53:57 PDT 
Comment on attachment 135314 [details]
Patch

r=me
Comment 7 WebKit Review Bot 2012-04-03 07:18:37 PDT 
Comment on attachment 135314 [details]
Patch

Clearing flags on attachment: 135314

Committed r113031: <http://trac.webkit.org/changeset/113031>
Comment 8 WebKit Review Bot 2012-04-03 07:18:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Luke Macpherson 2012-04-03 19:14:32 PDT 
Comment on attachment 135314 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135314&action=review

> Source/WebCore/css/CSSParser.h:-230
> -    bool parseRegionThread(int propId, bool important);

I really don't think you want to remove the "bool important" in this, or any other patch. That's important information that cannot be inferred from the type (unlike the propertyId, once using CSSPropertyID). Please fix here and everywhere!
Comment 10 Alexis Menard (darktears) 2012-04-04 06:56:24 PDT 
(In reply to comment #9)
> (From update of attachment 135314 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135314&action=review
> 
> > Source/WebCore/css/CSSParser.h:-230
> > -    bool parseRegionThread(int propId, bool important);
> 
> I really don't think you want to remove the "bool important" in this, or any other patch. That's important information that cannot be inferred from the type (unlike the propertyId, once using CSSPropertyID). Please fix here and everywhere!

https://bugs.webkit.org/show_bug.cgi?id=83151 fixes variable names removed too aggressively in some .h files.