[Part 2] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
Created attachment 135230 [details] Patch
Comment on attachment 135230 [details] Patch Attachment 135230 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12309847
Created attachment 135249 [details] Patch Rebased patch
Comment on attachment 135249 [details] Patch Attachment 135249 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12307910
Created attachment 135314 [details] Patch Should fix the mac build
Comment on attachment 135314 [details] Patch r=me
Comment on attachment 135314 [details] Patch Clearing flags on attachment: 135314 Committed r113031: <http://trac.webkit.org/changeset/113031>
All reviewed patches have been landed. Closing bug.
Comment on attachment 135314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135314&action=review > Source/WebCore/css/CSSParser.h:-230 > - bool parseRegionThread(int propId, bool important); I really don't think you want to remove the "bool important" in this, or any other patch. That's important information that cannot be inferred from the type (unlike the propertyId, once using CSSPropertyID). Please fix here and everywhere!
(In reply to comment #9) > (From update of attachment 135314 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135314&action=review > > > Source/WebCore/css/CSSParser.h:-230 > > - bool parseRegionThread(int propId, bool important); > > I really don't think you want to remove the "bool important" in this, or any other patch. That's important information that cannot be inferred from the type (unlike the propertyId, once using CSSPropertyID). Please fix here and everywhere! https://bugs.webkit.org/show_bug.cgi?id=83151 fixes variable names removed too aggressively in some .h files.