Bug 82966 - remove WebKit files from .gitattributes
Summary: remove WebKit files from .gitattributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 16:17 PDT by Tony Chang
Modified: 2012-04-03 22:18 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.20 KB, patch)
2012-04-02 16:18 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch (1.90 KB, patch)
2012-04-03 16:59 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2012-04-02 16:17:02 PDT
create Source/WebKit/.gitattributes and move entries from global .gitattributes
Comment 1 Tony Chang 2012-04-02 16:18:12 PDT
Created attachment 135220 [details]
Patch
Comment 2 Tony Chang 2012-04-03 16:01:07 PDT
I'm skeptical we need any of these since they didn't get updated when WebKit moved to Source.  Maybe we should just delete these entries?
Comment 3 David Barr 2012-04-03 16:23:15 PDT
From gitignore(5) which defines the pattern format used in gitattributes(5):
http://git-htmldocs.googlecode.com/git/gitignore.html#_pattern_format

* Otherwise, git treats the pattern as a shell glob suitable for consumption by fnmatch(3) with the FNM_PATHNAME flag: wildcards in the pattern will not match a / in the pathname. For example, "Documentation/*.html" matches "Documentation/git.html" but not "Documentation/ppc/ppc.html" or "tools/perf/Documentation/perf.html".

These rules ceased to apply since the since /WebKit moved into /Source.
I'm in favor of deleting these entries unless a compelling reason to update them is found.
Comment 4 Adam Barth 2012-04-03 16:57:59 PDT
> Maybe we should just delete these entries?

+1
Comment 5 Tony Chang 2012-04-03 16:59:16 PDT
Created attachment 135458 [details]
Patch
Comment 6 WebKit Review Bot 2012-04-03 22:18:20 PDT
Comment on attachment 135458 [details]
Patch

Clearing flags on attachment: 135458

Committed r113140: <http://trac.webkit.org/changeset/113140>
Comment 7 WebKit Review Bot 2012-04-03 22:18:24 PDT
All reviewed patches have been landed.  Closing bug.