Bug 82959 – [chromium] Enable sparkline FPS counter in threaded compositing mode

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Robinson]

[chromium] Enable sparkline FPS counter in threaded compositing mode

[James Robinson]

Created attachment 135210 [details]
Patch

[James Robinson]

This is a stopgap for debugging stability issues with the threaded scheduler more easily.

[Nat Duca]

Comment on attachment 135210 [details]
Patch

Did you consider making initFont and drawFPSCounterText early out rather than making the call conditional? No matter, LrGTM. :)

[James Robinson]

Yeah, I figured it was weirder to call a function and have it do nothing than to make the caller decide if it wanted to try to init fonts / draw the text.  Could go either way.

[Adrienne Walker]

Comment on attachment 135210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135210&action=review

R=me.  Just not drawing the text sounds like a reasonable short term solution.

> Source/WebCore/ChangeLog:12
> +        There are no tests for the HUD since it's a developer-facing feature and not user-facing.

ಠ_ಠ

[James Robinson]

Comment on attachment 135210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135210&action=review

>> Source/WebCore/ChangeLog:12
>> +        There are no tests for the HUD since it's a developer-facing feature and not user-facing.
> 
> ಠ_ಠ

¯\(°_o)/¯

[WebKit Review Bot]

Comment on attachment 135210 [details]
Patch

Clearing flags on attachment: 135210

Committed r113081: <http://trac.webkit.org/changeset/113081>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.