Bug 82959 - [chromium] Enable sparkline FPS counter in threaded compositing mode
Summary: [chromium] Enable sparkline FPS counter in threaded compositing mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 15:48 PDT by James Robinson
Modified: 2012-04-03 13:36 PDT (History)
5 users (show)

See Also:


Attachments
Patch (10.98 KB, patch)
2012-04-02 15:52 PDT, James Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-04-02 15:48:32 PDT
[chromium] Enable sparkline FPS counter in threaded compositing mode
Comment 1 James Robinson 2012-04-02 15:52:24 PDT
Created attachment 135210 [details]
Patch
Comment 2 James Robinson 2012-04-02 15:52:54 PDT
This is a stopgap for debugging stability issues with the threaded scheduler more easily.
Comment 3 Nat Duca 2012-04-02 15:59:57 PDT
Comment on attachment 135210 [details]
Patch

Did you consider making initFont and drawFPSCounterText early out rather than making the call conditional? No matter, LrGTM. :)
Comment 4 James Robinson 2012-04-02 16:05:32 PDT
Yeah, I figured it was weirder to call a function and have it do nothing than to make the caller decide if it wanted to try to init fonts / draw the text.  Could go either way.
Comment 5 Adrienne Walker 2012-04-03 13:24:44 PDT
Comment on attachment 135210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135210&action=review

R=me.  Just not drawing the text sounds like a reasonable short term solution.

> Source/WebCore/ChangeLog:12
> +        There are no tests for the HUD since it's a developer-facing feature and not user-facing.

ಠ_ಠ
Comment 6 James Robinson 2012-04-03 13:26:28 PDT
Comment on attachment 135210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135210&action=review

>> Source/WebCore/ChangeLog:12
>> +        There are no tests for the HUD since it's a developer-facing feature and not user-facing.
> 
> ಠ_ಠ

¯\(°_o)/¯
Comment 7 WebKit Review Bot 2012-04-03 13:36:47 PDT
Comment on attachment 135210 [details]
Patch

Clearing flags on attachment: 135210

Committed r113081: <http://trac.webkit.org/changeset/113081>
Comment 8 WebKit Review Bot 2012-04-03 13:36:51 PDT
All reviewed patches have been landed.  Closing bug.