NOT FOR REVIEW. Adds ability to take snapshot of partially occluded window
Created attachment 135205 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Attachment 135205 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1 Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:1146: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:117: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp:117: Use 0 instead of NULL. [readability/null] [5] Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:413: Use 0 instead of NULL. [readability/null] [5] Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:85: Should have a space between // and comment [whitespace/comments] [4] Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:94: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:94: Use 0 instead of NULL. [readability/null] [5] Total errors found: 8 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 135205 [details] Patch If it's not for review then don't set the review? flags. If you're using webkit-patch, upload with --no-review. Setting review? and putting "NOT FOR REVIEW" in the ChangeLog just generates noise. You can still run the EWS bots manually for patches that do not have review? set by clicking on the box in the bugzilla UI.
Comment on attachment 135205 [details] Patch Attachment 135205 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12309816 New failing tests: compositing/checkerboard.html compositing/absolute-position-changed-in-composited-layer.html accessibility/aria-disabled.html compositing/backface-visibility.html compositing/direct-image-compositing.html animations/3d/matrix-transform-type-animation.html compositing/layers-inside-overflow-scroll.html compositing/compositing-visible-descendant.html animations/3d/state-at-end-event-transform.html animations/missing-values-first-keyframe.html compositing/flat-with-transformed-child.html compositing/fixed-position-changed-within-composited-parent-layer.html compositing/generated-content.html compositing/fixed-position-changed-in-composited-layer.html animations/additive-transform-animations.html animations/3d/replace-filling-transform.html animations/3d/change-transform-in-end-event.html compositing/scroll-painted-composited-content.html compositing/backface-visibility-hierarchical-transform.html compositing/absolute-position-changed-with-composited-parent-layer.html
Created attachment 135222 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Can you just not set the review flag rather than titling bugs NOT FOR REVIEW?
https://code.google.com/p/chromium/issues/detail?id=231308