Bug 82946 - Rename GraphicsContext::drawLineForTextChecking() to GraphicsContext::drawLineForDocumentMarker()
Summary: Rename GraphicsContext::drawLineForTextChecking() to GraphicsContext::drawLin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh Intel OS X 10.7
: P2 Normal
Assignee: Jia Pu
URL:
Keywords: InRadar
Depends on:
Blocks: 82503
  Show dependency treegraph
 
Reported: 2012-04-02 14:25 PDT by Jia Pu
Modified: 2012-04-03 10:43 PDT (History)
1 user (show)

See Also:


Attachments
Patch (V1) (14.78 KB, patch)
2012-04-02 16:44 PDT, Jia Pu
no flags Details | Formatted Diff | Diff
Fixed a typo. (14.78 KB, patch)
2012-04-03 09:02 PDT, Jia Pu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jia Pu 2012-04-02 14:25:22 PDT
On OSX, we draw similar underline on dictated text that has alternative text. We should rename this function, so that we can reuse it with dictation.
Comment 1 Jia Pu 2012-04-02 14:37:12 PDT
<rdar://problem/11169336>
Comment 2 Jia Pu 2012-04-02 16:44:28 PDT
Created attachment 135227 [details]
Patch (V1)
Comment 3 Mark Rowe (bdash) 2012-04-02 19:43:57 PDT
It is OS X, not OSX.
Comment 4 Simon Fraser (smfr) 2012-04-02 19:51:36 PDT
Comment on attachment 135227 [details]
Patch (V1)

View in context: https://bugs.webkit.org/attachment.cgi?id=135227&action=review

> Source/WebCore/ChangeLog:8
> +        On OSX, we draw similar underline on dictated text that has alternative text. We rename

OS X
Comment 5 Jia Pu 2012-04-03 09:02:04 PDT
Created attachment 135338 [details]
Fixed a typo.
Comment 6 Enrica Casucci 2012-04-03 10:16:21 PDT
Comment on attachment 135338 [details]
Fixed a typo.

Looks good.
Comment 7 WebKit Review Bot 2012-04-03 10:43:03 PDT
Comment on attachment 135338 [details]
Fixed a typo.

Clearing flags on attachment: 135338

Committed r113059: <http://trac.webkit.org/changeset/113059>
Comment 8 WebKit Review Bot 2012-04-03 10:43:07 PDT
All reviewed patches have been landed.  Closing bug.