Bug 82944 - [mac] LayoutTestHelper crashes if there is no main display
Summary: [mac] LayoutTestHelper crashes if there is no main display
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-04-02 14:12 PDT by Tim Horton
Modified: 2012-04-02 14:24 PDT (History)
2 users (show)

See Also:

Attachments
patch (2.12 KB, patch)
2012-04-02 14:14 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2012-04-02 14:12:22 PDT 
It looks like LayoutTestHelper is crashing on some of the bots because ColorSyncDeviceCopyDeviceInfo returns null. It looks like this is probably due to them not having a display. We should check for this case and not do anything to the main display color profile, since I don't see how we can! I'm not sure what will happen to the colorspace of pixel results in that situation, but fixing this can't make it *worse*.
Comment 1 Tim Horton 2012-04-02 14:12:42 PDT 
<rdar://problem/11162954>
Comment 2 Tim Horton 2012-04-02 14:14:57 PDT 
Created attachment 135183 [details]
patch
Comment 3 Tim Horton 2012-04-02 14:24:25 PDT 
Landed in http://trac.webkit.org/changeset/112943