Simplify CSSStyleSelector constructor through the use of a helper function
Created attachment 135171 [details] Patch
Comment on attachment 135171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135171&action=review > Source/WebCore/css/CSSStyleSelector.cpp:410 > +void CSSStyleSelector::addAuthorRulesAndCollectUserRulesFromSheets(const Vector<RefPtr<CSSStyleSheet> >* userSheets, RuleSet& userStyle) While I see the benefit of the patch to avoid code duplication, I'm not sure whether it's part of the usage to pass a object by reference to modify it.
See http://www.webkit.org/coding/coding-style.html "Pointers and References" for minimal guidance on the subject. In short: yes, we do pass by reference at times.
"An out argument of a function should be passed by reference except rare cases where it is optional in which case it should be passed by pointer." seems to suggest that we prefer references to pointers. :)
Comment on attachment 135171 [details] Patch Attachment 135171 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12310679
Comment on attachment 135171 [details] Patch gtk lies!
Comment on attachment 135171 [details] Patch Clearing flags on attachment: 135171 Committed r113016: <http://trac.webkit.org/changeset/113016>
All reviewed patches have been landed. Closing bug.