Bug 82935 - Simplify main resource load start/end in FrameLoader and DocumentLoader.
Summary: Simplify main resource load start/end in FrameLoader and DocumentLoader.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 13:28 PDT by Nate Chapin
Modified: 2012-04-02 15:08 PDT (History)
3 users (show)

See Also:


Attachments
patch (9.75 KB, patch)
2012-04-02 13:33 PDT, Nate Chapin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2012-04-02 13:28:11 PDT
Examples:
* A circular call in FrameLoader -> DocumentLoader::prepareForLoadStart() -> FrameLoader::prepareForLoadStart().
* DocumentLoader::m_primaryLoadComplete is basically the same as a non-null m_mainResourceLoader.

I've got a couple of other small ones, patch shortly.
Comment 1 Nate Chapin 2012-04-02 13:33:46 PDT
Created attachment 135170 [details]
patch
Comment 2 Adam Barth 2012-04-02 14:23:29 PDT
Comment on attachment 135170 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135170&action=review

> Source/WebCore/WebCore.exp.in:-330
> -__ZN7WebCore14DocumentLoader19prepareForLoadStartEv

Are there no callers in the WebKit-layer anymore?
Comment 3 Nate Chapin 2012-04-02 14:26:36 PDT
(In reply to comment #2)
> (From update of attachment 135170 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135170&action=review
> 
> > Source/WebCore/WebCore.exp.in:-330
> > -__ZN7WebCore14DocumentLoader19prepareForLoadStartEv
> 
> Are there no callers in the WebKit-layer anymore?

According to http://code.google.com/searchframe#search/&exact_package=chromium&q=prepareForLoadStart&type=cs , it's only called from FrameLoader.
Comment 4 Adam Barth 2012-04-02 14:30:26 PDT
Comment on attachment 135170 [details]
patch

Ok.
Comment 5 WebKit Review Bot 2012-04-02 15:08:37 PDT
Comment on attachment 135170 [details]
patch

Clearing flags on attachment: 135170

Committed r112949: <http://trac.webkit.org/changeset/112949>
Comment 6 WebKit Review Bot 2012-04-02 15:08:42 PDT
All reviewed patches have been landed.  Closing bug.