RESOLVED FIXED 82935
Simplify main resource load start/end in FrameLoader and DocumentLoader. 
https://bugs.webkit.org/show_bug.cgi?id=82935
Summary Simplify main resource load start/end in FrameLoader and DocumentLoader.
Nate Chapin
Reported 2012-04-02 13:28:11 PDT
Examples: * A circular call in FrameLoader -> DocumentLoader::prepareForLoadStart() -> FrameLoader::prepareForLoadStart(). * DocumentLoader::m_primaryLoadComplete is basically the same as a non-null m_mainResourceLoader. I've got a couple of other small ones, patch shortly.
Attachments
patch (9.75 KB, patch)
2012-04-02 13:33 PDT, Nate Chapin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2012-04-02 13:33:46 PDT
Created attachment 135170 [details] patch
Adam Barth
Comment 2 2012-04-02 14:23:29 PDT
Comment on attachment 135170 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=135170&action=review > Source/WebCore/WebCore.exp.in:-330 > -__ZN7WebCore14DocumentLoader19prepareForLoadStartEv Are there no callers in the WebKit-layer anymore?
Nate Chapin
Comment 3 2012-04-02 14:26:36 PDT
(In reply to comment #2) > (From update of attachment 135170 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135170&action=review > > > Source/WebCore/WebCore.exp.in:-330 > > -__ZN7WebCore14DocumentLoader19prepareForLoadStartEv > > Are there no callers in the WebKit-layer anymore? According to http://code.google.com/searchframe#search/&exact_package=chromium&q=prepareForLoadStart&type=cs , it's only called from FrameLoader.
Adam Barth
Comment 4 2012-04-02 14:30:26 PDT
Comment on attachment 135170 [details] patch Ok.
WebKit Review Bot
Comment 5 2012-04-02 15:08:37 PDT
Comment on attachment 135170 [details] patch Clearing flags on attachment: 135170 Committed r112949: <http://trac.webkit.org/changeset/112949>
WebKit Review Bot
Comment 6 2012-04-02 15:08:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.