Bug 82925 - Add layout test expectations for Chromium to exhibit support WebM types
: Add layout test expectations for Chromium to exhibit support WebM types
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-04-02 12:22 PST by
Modified: 2012-04-19 15:50 PST (History)


Attachments
Patch (4.74 KB, patch)
2012-04-02 12:27 PST, David Dorwin
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-04-02 12:22:21 PST
Chromium layout tests have been running without WebM support because of layout test-specific code. That is being removed (http://crbug.com/119667), so some tests that previously used the default expectations need to be overrides.
------- Comment #1 From 2012-04-02 12:27:06 PST -------
Created an attachment (id=135153) [details]
Patch
------- Comment #2 From 2012-04-02 13:36:32 PST -------
(From update of attachment 135153 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=135153&action=review

> LayoutTests/platform/chromium/test_expectations.txt:4300
> +BUGCR119667 : media/W3C/video/canPlayType/canPlayType_codecs_order_1.html = PASS FAIL

why are these PASS FAIL?

should we wait for the chromium side change to land first?
------- Comment #3 From 2012-04-02 13:56:57 PST -------
Per offline discussion, I'm committing the WebKit side first, so these will start to pass when the Chromium change lands. I'll then remove these lines.
------- Comment #4 From 2012-04-02 14:05:50 PST -------
Committed as http://trac.webkit.org/changeset/112937
------- Comment #5 From 2012-04-19 15:50:14 PST -------
(From update of attachment 135153 [details])
Cleared review? from attachment 135153 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).