WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
82925
Add layout test expectations for Chromium to exhibit support WebM types
https://bugs.webkit.org/show_bug.cgi?id=82925
Summary
Add layout test expectations for Chromium to exhibit support WebM types
David Dorwin
Reported
2012-04-02 12:22:21 PDT
Chromium layout tests have been running without WebM support because of layout test-specific code. That is being removed (
http://crbug.com/119667
), so some tests that previously used the default expectations need to be overrides.
Attachments
Patch
(4.74 KB, patch)
2012-04-02 12:27 PDT
,
David Dorwin
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
David Dorwin
Comment 1
2012-04-02 12:27:06 PDT
Created
attachment 135153
[details]
Patch
Andrew Scherkus
Comment 2
2012-04-02 13:36:32 PDT
Comment on
attachment 135153
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=135153&action=review
> LayoutTests/platform/chromium/test_expectations.txt:4300 > +BUGCR119667 : media/W3C/video/canPlayType/canPlayType_codecs_order_1.html = PASS FAIL
why are these PASS FAIL? should we wait for the chromium side change to land first?
David Dorwin
Comment 3
2012-04-02 13:56:57 PDT
Per offline discussion, I'm committing the WebKit side first, so these will start to pass when the Chromium change lands. I'll then remove these lines.
Andrew Scherkus
Comment 4
2012-04-02 14:05:50 PDT
Committed as
http://trac.webkit.org/changeset/112937
Eric Seidel (no email)
Comment 5
2012-04-19 15:50:14 PDT
Comment on
attachment 135153
[details]
Patch Cleared review? from
attachment 135153
[details]
so that this bug does not appear in
http://webkit.org/pending-review
. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug