Bug 82922 - border-image with image-set does not render correctly when viewed at 2x
Summary: border-image with image-set does not render correctly when viewed at 2x
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-04-02 11:56 PDT by Timothy Hatcher
Modified: 2012-04-30 08:42 PDT (History)
5 users (show)

See Also:


Attachments
Test Case (885 bytes, text/html)
2012-04-02 11:56 PDT, Timothy Hatcher
no flags Details
Image 1x (385 bytes, image/png)
2012-04-02 11:57 PDT, Timothy Hatcher
no flags Details
Image 2x (800 bytes, image/png)
2012-04-02 11:57 PDT, Timothy Hatcher
no flags Details
Patch (87.14 KB, patch)
2012-04-27 17:25 PDT, Beth Dakin
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2012-04-02 11:56:58 PDT
Created attachment 135145 [details]
Test Case

A -webkit-image-set() in a border-image does not render correctly when viewed at 2x. You need to use a media query to make border-image work still. See attached test case with images.
Comment 1 Radar WebKit Bug Importer 2012-04-02 11:57:29 PDT
<rdar://problem/11167820>
Comment 2 Timothy Hatcher 2012-04-02 11:57:30 PDT
Created attachment 135146 [details]
Image 1x
Comment 3 Timothy Hatcher 2012-04-02 11:57:46 PDT
Created attachment 135147 [details]
Image 2x
Comment 4 Beth Dakin 2012-04-27 17:25:09 PDT
Created attachment 139310 [details]
Patch
Comment 5 mitz 2012-04-27 18:01:22 PDT
Comment on attachment 139310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=139310&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:1084
> +    float imageScaleFactorAdjustRatio = 1 / image->imageScaleFactor();

Not sure this variable is needed. The word “ratio” doesn’t mean “reciprocal”, so this name is rather meaningless.
Comment 6 Beth Dakin 2012-04-30 08:42:47 PDT
Thanks Dan! I got rid of that variable you didn't like: http://trac.webkit.org/changeset/115641