Bug 82917 - [Qt][WK2] ResourceError::isCancellation() is always returning false
Summary: [Qt][WK2] ResourceError::isCancellation() is always returning false
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jesus Sanchez-Palencia
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2012-04-02 11:24 PDT by Jesus Sanchez-Palencia
Modified: 2012-04-02 12:47 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.25 KB, patch)
2012-04-02 11:45 PDT, Jesus Sanchez-Palencia 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesus Sanchez-Palencia 2012-04-02 11:24:29 PDT 
We are missing the encoding of a boolean in ArgumentCoder<ResourceError> and, therefore, we always get the default value (false) for ResourceError::isCancellation() with errors being sent through the IPC.

This is impacting directly the implementation of QtWebPageLoadClient::dispatchLoadFailed, line 95.
Comment 1 Jesus Sanchez-Palencia 2012-04-02 11:45:38 PDT 
Created attachment 135142 [details]
Patch
Comment 2 Jesus Sanchez-Palencia 2012-04-02 12:46:55 PDT 
Comment on attachment 135142 [details]
Patch

Clearing flags on attachment: 135142

Committed r112921: <http://trac.webkit.org/changeset/112921>
Comment 3 Jesus Sanchez-Palencia 2012-04-02 12:47:02 PDT 
All reviewed patches have been landed.  Closing bug.