Bug 82906 - Suppress HTMLMediaElement's text track code when !webkitVideoTrackEnabled()
Summary: Suppress HTMLMediaElement's text track code when !webkitVideoTrackEnabled()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ami Fischman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 08:56 PDT by Ami Fischman
Modified: 2012-04-02 10:16 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.19 KB, patch)
2012-04-02 08:57 PDT, Ami Fischman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ami Fischman 2012-04-02 08:56:35 PDT 
HTMLMediaElement used to double-guard text track code with both an ENABLE(VIDEO_TRACK) and a RuntimeEnabledFeatures::webkitVideoTrackEnabled() check.  But various more-recent CLs (99984, 100064, 102968, 107831, 108241) appear to only use the ENABLE check, effectively turning on a bunch of text track code (visible e.g. with --webcore-log-channels=Media in chromium).
Comment 1 Ami Fischman 2012-04-02 08:57:46 PDT 
Created attachment 135111 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-02 10:16:19 PDT 
Comment on attachment 135111 [details]
Patch

Clearing flags on attachment: 135111

Committed r112900: <http://trac.webkit.org/changeset/112900>
Comment 3 WebKit Review Bot 2012-04-02 10:16:24 PDT 
All reviewed patches have been landed.  Closing bug.