WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
82906
Suppress HTMLMediaElement's text track code when !webkitVideoTrackEnabled()
https://bugs.webkit.org/show_bug.cgi?id=82906
Summary
Suppress HTMLMediaElement's text track code when !webkitVideoTrackEnabled()
Ami Fischman
Reported
2012-04-02 08:56:35 PDT
HTMLMediaElement used to double-guard text track code with both an ENABLE(VIDEO_TRACK) and a RuntimeEnabledFeatures::webkitVideoTrackEnabled() check. But various more-recent CLs (99984, 100064, 102968, 107831, 108241) appear to only use the ENABLE check, effectively turning on a bunch of text track code (visible e.g. with --webcore-log-channels=Media in chromium).
Attachments
Patch
(5.19 KB, patch)
2012-04-02 08:57 PDT
,
Ami Fischman
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ami Fischman
Comment 1
2012-04-02 08:57:46 PDT
Created
attachment 135111
[details]
Patch
WebKit Review Bot
Comment 2
2012-04-02 10:16:19 PDT
Comment on
attachment 135111
[details]
Patch Clearing flags on attachment: 135111 Committed
r112900
: <
http://trac.webkit.org/changeset/112900
>
WebKit Review Bot
Comment 3
2012-04-02 10:16:24 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug