Bug 82897 - Move GeolocationClient.h to Modules/geolocation/
Summary: Move GeolocationClient.h to Modules/geolocation/
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Pilgrim (Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 07:33 PDT by Mark Pilgrim (Google)
Modified: 2013-01-16 09:54 PST (History)
7 users (show)

See Also:

Attachments
Patch (8.66 KB, patch)
2012-04-02 07:34 PDT, Mark Pilgrim (Google) 		no flags Details | Formatted Diff | Diff
Patch (12.35 KB, patch)
2012-04-02 09:09 PDT, Mark Pilgrim (Google) 		haraken: review-
buildbot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Pilgrim (Google) 2012-04-02 07:33:08 PDT 
Move GeolocationClient.h to Modules/geolocation/
Comment 1 Mark Pilgrim (Google) 2012-04-02 07:34:01 PDT 
Created attachment 135098 [details]
Patch
Comment 2 Mark Pilgrim (Google) 2012-04-02 07:40:52 PDT 
Comment on attachment 135098 [details]
Patch

This touches some platform-specific build files, so let's wait for all the bots to turn green.
Comment 3 Kentaro Hara 2012-04-02 07:42:40 PDT 
Comment on attachment 135098 [details]
Patch

cq+ is a safe approach. If any build fails, the bot will change it to cq- automatically.
Comment 4 Build Bot 2012-04-02 07:49:29 PDT 
Comment on attachment 135098 [details]
Patch

Attachment 135098 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12314002
Comment 5 Mark Pilgrim (Google) 2012-04-02 09:09:30 PDT 
Created attachment 135117 [details]
Patch
Comment 6 Mark Pilgrim (Google) 2012-04-02 09:09:57 PDT 
Comment on attachment 135117 [details]
Patch

Fixed Mac build.
Comment 7 Build Bot 2012-04-02 09:21:26 PDT 
Comment on attachment 135117 [details]
Patch

Attachment 135117 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12310552
Comment 8 Philippe Normand 2012-04-02 09:37:45 PDT 
Comment on attachment 135117 [details]
Patch

Attachment 135117 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12310559
Comment 9 Gyuyoung Kim 2012-04-02 10:34:09 PDT 
Comment on attachment 135117 [details]
Patch

Attachment 135117 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12307693
Comment 10 Early Warning System Bot 2012-04-02 10:48:39 PDT 
Comment on attachment 135117 [details]
Patch

Attachment 135117 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12309654
Comment 11 Kentaro Hara 2012-04-19 16:17:23 PDT 
Comment on attachment 135117 [details]
Patch

The change looks OK. Marking r- due to build failures.