Bug 82879 - Remove TreeScope::isShadowRoot()
Summary: Remove TreeScope::isShadowRoot()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 03:42 PDT by Shinya Kawanaka
Modified: 2012-04-02 20:01 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.06 KB, patch)
2012-04-02 05:52 PDT, Shinya Kawanaka 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shinya Kawanaka 2012-04-02 03:42:27 PDT 
It seems weird that TreeScope has isShadowRoot().
We should do treeScope->rootNode()->isShadowRoot. Since rootNode() is inlined, the overall performance won't change.
Comment 1 Shinya Kawanaka 2012-04-02 04:00:45 PDT 
Because of this existence, some code requires to include non-necessary ShadowRoot.h...
Comment 2 Shinya Kawanaka 2012-04-02 05:52:29 PDT 
Created attachment 135080 [details]
Patch
Comment 3 WebKit Review Bot 2012-04-02 20:01:06 PDT 
Comment on attachment 135080 [details]
Patch

Clearing flags on attachment: 135080

Committed r112978: <http://trac.webkit.org/changeset/112978>
Comment 4 WebKit Review Bot 2012-04-02 20:01:10 PDT 
All reviewed patches have been landed.  Closing bug.