Bug 82872 - [V8] Web Inspector: don't crash when resolving DOM wrapper heap snapshot node to JS object
Summary: [V8] Web Inspector: don't crash when resolving DOM wrapper heap snapshot node...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 02:44 PDT by Yury Semikhatsky
Modified: 2012-04-02 05:14 PDT (History)
15 users (show)

See Also:


Attachments
Patch (7.32 KB, patch)
2012-04-02 02:47 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-02 (7.45 MB, application/zip)
2012-04-02 04:45 PDT, WebKit Review Bot
no flags Details
Patch (11.56 KB, patch)
2012-04-02 04:59 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (11.53 KB, patch)
2012-04-02 05:10 PDT, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-04-02 02:44:38 PDT
For each DOM wrapper in V8 bindings there is a boilerplate object which doesn't have a pointer to the native object and will fail on attempt to work with it. Inspector shouldn't resolve such objects.
Comment 1 Yury Semikhatsky 2012-04-02 02:47:09 PDT
Created attachment 135050 [details]
Patch
Comment 2 WebKit Review Bot 2012-04-02 04:45:42 PDT
Comment on attachment 135050 [details]
Patch

Attachment 135050 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12310463

New failing tests:
inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
Comment 3 WebKit Review Bot 2012-04-02 04:45:49 PDT
Created attachment 135065 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 Ilya Tikhonovsky 2012-04-02 04:54:33 PDT
Comment on attachment 135050 [details]
Patch

lgtm
Comment 5 Yury Semikhatsky 2012-04-02 04:59:55 PDT
Created attachment 135069 [details]
Patch
Comment 6 Yury Semikhatsky 2012-04-02 05:10:19 PDT
Created attachment 135070 [details]
Patch
Comment 7 Yury Semikhatsky 2012-04-02 05:13:27 PDT
Committed r112861: <http://trac.webkit.org/changeset/112861>