Disable ENABLE_INPUT_TYPE_COLOR for aura and android. I turned them on by mistake but the UIs aren't ready.
Created attachment 135037 [details] Patch
Comment on attachment 135037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135037&action=review Have you tested this? This will define ENABLE_INPUT_TYPE_COLOR multiple times, which will cause compiler warnings. Output for an Android build: <command-line>: warning: "ENABLE_INPUT_TYPE_COLOR" redefined <command-line>: warning: this is the location of the previous definition Disabling this feature for Android LGTM, at least until the Chromium-side implementation is complete. > Source/WebKit/chromium/features.gypi:141 > + 'feature_defines': [ nit: indenting.
Comment on attachment 135037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135037&action=review > Source/WebKit/chromium/features.gypi:140 > + ['OS=="android" or use_aura==1',{ one more nit: space after the comma.
Created attachment 135039 [details] Patch
(In reply to comment #2) > (From update of attachment 135037 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=135037&action=review > > Have you tested this? This will define ENABLE_INPUT_TYPE_COLOR multiple times, which will cause compiler warnings. Output for an Android build: Sorry. I didn't have an android or aura build environment.
Comment on attachment 135039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=135039&action=review Thank you! There's one more thing you'll want to adjust, namely that Mac is being excluded now instead of Android. Deferring to tkent/a reviewer now :-). > Source/WebKit/chromium/features.gypi:139 > + ['OS=="mac" or use_aura==1', { s/mac/android/
Created attachment 135045 [details] Patch
Created attachment 135046 [details] Patch
Comment on attachment 135046 [details] Patch ok
Comment on attachment 135046 [details] Patch Clearing flags on attachment: 135046 Committed r112849: <http://trac.webkit.org/changeset/112849>
All reviewed patches have been landed. Closing bug.