Bug 82863 - [chromium] Disable ENABLE_INPUT_TYPE_COLOR for aura and android
Summary: [chromium] Disable ENABLE_INPUT_TYPE_COLOR for aura and android
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-02 00:37 PDT by Keishi Hattori
Modified: 2012-04-02 03:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.22 KB, patch)
2012-04-02 00:46 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (1.57 KB, patch)
2012-04-02 01:18 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (1.58 KB, patch)
2012-04-02 02:01 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Patch (1.58 KB, patch)
2012-04-02 02:04 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-04-02 00:37:07 PDT 
Disable ENABLE_INPUT_TYPE_COLOR for aura and android.
I turned them on by mistake but the UIs aren't ready.
Comment 1 Keishi Hattori 2012-04-02 00:46:13 PDT 
Created attachment 135037 [details]
Patch
Comment 2 Peter Beverloo 2012-04-02 00:54:08 PDT 
Comment on attachment 135037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135037&action=review

Have you tested this? This will define ENABLE_INPUT_TYPE_COLOR multiple times, which will cause compiler warnings. Output for an Android build:

<command-line>: warning: "ENABLE_INPUT_TYPE_COLOR" redefined
<command-line>: warning: this is the location of the previous definition

Disabling this feature for Android LGTM, at least until the Chromium-side implementation is complete.

> Source/WebKit/chromium/features.gypi:141
> +          'feature_defines': [

nit: indenting.
Comment 3 Peter Beverloo 2012-04-02 00:57:16 PDT 
Comment on attachment 135037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135037&action=review

> Source/WebKit/chromium/features.gypi:140
> +      ['OS=="android" or use_aura==1',{

one more nit: space after the comma.
Comment 4 Keishi Hattori 2012-04-02 01:18:36 PDT 
Created attachment 135039 [details]
Patch
Comment 5 Keishi Hattori 2012-04-02 01:20:10 PDT 
(In reply to comment #2)
> (From update of attachment 135037 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=135037&action=review
> 
> Have you tested this? This will define ENABLE_INPUT_TYPE_COLOR multiple times, which will cause compiler warnings. Output for an Android build:
Sorry. I didn't have an android or aura build environment.
Comment 6 Peter Beverloo 2012-04-02 01:47:56 PDT 
Comment on attachment 135039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=135039&action=review

Thank you! There's one more thing you'll want to adjust, namely that Mac is being excluded now instead of Android. Deferring to tkent/a reviewer now :-).

> Source/WebKit/chromium/features.gypi:139
> +      ['OS=="mac" or use_aura==1', {

s/mac/android/
Comment 7 Keishi Hattori 2012-04-02 02:01:25 PDT 
Created attachment 135045 [details]
Patch
Comment 8 Keishi Hattori 2012-04-02 02:04:43 PDT 
Created attachment 135046 [details]
Patch
Comment 9 Kent Tamura 2012-04-02 02:16:03 PDT 
Comment on attachment 135046 [details]
Patch

ok
Comment 10 WebKit Review Bot 2012-04-02 03:20:43 PDT 
Comment on attachment 135046 [details]
Patch

Clearing flags on attachment: 135046

Committed r112849: <http://trac.webkit.org/changeset/112849>
Comment 11 WebKit Review Bot 2012-04-02 03:20:47 PDT 
All reviewed patches have been landed.  Closing bug.